Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rating): add customization to aria-valuetext #4453

Merged

Conversation

ValentinNelu
Copy link
Contributor

Small PR to add the possibility to change the aria-valuetext in the rating component.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Base: 88.66% // Head: 88.68% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (f64918c) compared to base (379dae2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4453      +/-   ##
==========================================
+ Coverage   88.66%   88.68%   +0.01%     
==========================================
  Files         114      114              
  Lines        3998     4003       +5     
  Branches      843      844       +1     
==========================================
+ Hits         3545     3550       +5     
  Misses        413      413              
  Partials       40       40              
Flag Coverage Δ
e2e 54.52% <ø> (+<0.01%) ⬆️
unit 89.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rating/rating.ts 84.93% <0.00%> (ø)
src/popover/popover.ts 95.12% <0.00%> (ø)
src/tooltip/tooltip.ts 98.57% <0.00%> (ø)
src/util/positioning.ts 100.00% <0.00%> (ø)
src/dropdown/dropdown.ts 91.42% <0.00%> (ø)
src/modal/modal.module.ts 100.00% <0.00%> (ø)
src/typeahead/typeahead.ts 96.35% <0.00%> (ø)
src/datepicker/datepicker.ts 97.97% <0.00%> (ø)
src/progressbar/progressbar.ts 68.18% <0.00%> (ø)
src/datepicker/datepicker-input.ts 95.51% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ValentinNelu, thanks!

Added a couple of comments about the API

src/rating/rating.ts Outdated Show resolved Hide resolved
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Looks much simpler now!

Will merge when CI is green

@maxokorokov maxokorokov merged commit 064fef3 into ng-bootstrap:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants