Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progressbar): aria attributes in parent and class text-bg-color when no textType #4461

Merged

Conversation

bastienmoulia
Copy link
Contributor

@bastienmoulia bastienmoulia commented Jan 6, 2023

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md and DEVELOPER.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

Fix #4456
Fix #4457

@codecov-commenter
Copy link

Codecov Report

Base: 88.66% // Head: 88.67% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (32a07a2) compared to base (379dae2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4461   +/-   ##
=======================================
  Coverage   88.66%   88.67%           
=======================================
  Files         114      114           
  Lines        3998     4000    +2     
  Branches      843      843           
=======================================
+ Hits         3545     3547    +2     
  Misses        413      413           
  Partials       40       40           
Flag Coverage Δ
e2e 54.51% <ø> (-0.01%) ⬇️
unit 89.10% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/popover/popover.ts 95.12% <0.00%> (ø)
src/tooltip/tooltip.ts 98.57% <0.00%> (ø)
src/util/positioning.ts 100.00% <0.00%> (ø)
src/dropdown/dropdown.ts 91.42% <0.00%> (ø)
src/typeahead/typeahead.ts 96.35% <0.00%> (ø)
src/datepicker/datepicker.ts 97.97% <0.00%> (ø)
src/progressbar/progressbar.ts 68.18% <0.00%> (ø)
src/datepicker/datepicker-input.ts 95.51% <0.00%> (ø)
src/accordion/accordion.ts 79.36% <0.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants