Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus is going out of the modal, if it is having hidden button as the last interactive element. #4630

Open
AHarshini opened this issue Nov 17, 2023 · 4 comments · May be fixed by #4643
Open

Focus is going out of the modal, if it is having hidden button as the last interactive element. #4630

AHarshini opened this issue Nov 17, 2023 · 4 comments · May be fixed by #4643
Labels
component: modal type: bug

Comments

@AHarshini
Copy link

AHarshini commented Nov 17, 2023 •
edited

Bug description:
While traversing through the elements, focus is going out of the modal if last interactive button is hidden on modal.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 15.2

ng-bootstrap: 14

Bootstrap: 6
@maxokorokov
Copy link
Member

Would you have a reproduction scenario for this, please ?
You can use the StackBlitz from this page → https://ng-bootstrap.github.io/#/components/modal/examples#basic

@AHarshini
Copy link
Author

please find demo link:
https://stackblitz.com/edit/angular-gv4mmm?file=src%2Fapp%2Fmodal-basic.html

@bastienmoulia bastienmoulia linked a pull request Dec 6, 2023 that will close this issue
Open
@SAndrecovich
Copy link

Great, thank you! @bastienmoulia @maxokorokov is there an ETA for when the PR will be reviewed?

@SAndrecovich
Copy link

Hi - following up on this PR. Is there an ETA on the review? Thank you
@bastienmoulia @maxokorokov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: modal type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modal): focusable boundary without display none bastienmoulia/ng-bootstrap
3 participants
@maxokorokov @AHarshini @SAndrecovich