Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright code coverage structure #4650

Open
sh977218 opened this issue Dec 15, 2023 · 0 comments
Open

Playwright code coverage structure #4650

sh977218 opened this issue Dec 15, 2023 · 0 comments

Comments

@sh977218
Copy link

sh977218 commented Dec 15, 2023

Please remember, the issues forum is NOT for support requests. It is for bugs and feature requests only.
Please read https://github.com/ng-bootstrap/ng-bootstrap/blob/master/CONTRIBUTING.md and search
existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.

Bug description:

This is not a bug report, but more like a code refectory.
In e2e-app's playwright global setup function, it actually returns a function, which will run during global teardown, as documented by playwright. I spent quite some time to figure that out.
I think having a more straightforward two separated playwright file, global setup and teardown, would help others understood easier.
I'm happy to pull a PR to do this fix. If I can get an affirmative response first.

Link to minimally-working StackBlitz that reproduces the issue:

You can fork a StackBlitz from one of our demos and use it as a starting point.

Please note that we can not act on bug reports without a minimal reproduction scenario in a StackBlitz. Here is why:
https://github.com/ng-bootstrap/ng-bootstrap#you-think-youve-found-a-bug

Versions of Angular, ng-bootstrap and Bootstrap:

Angular:

ng-bootstrap:

Bootstrap:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant