Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngbAccordionCollapse does not collapse when ngbAccordionItem is disabled #4667

Open
DanielRose opened this issue Jan 26, 2024 · 0 comments
Open

Comments

@DanielRose
Copy link

Bug description:

When an ngbAccordionItem is disabled, the ngbAccordionCollapse is not collapsed (and the content is not disabled). This is a breaking change from the component-based accordion.

Compare the "Custom header" demo in the current version with the old release (https://ng-bootstrap.github.io/releases/13.x/#/components/accordion/examples).

Link to minimally-working StackBlitz that reproduces the issue:

Based on the default "Custom header" demo: https://stackblitz.com/edit/angular-oz5acv?file=src%2Fapp%2Faccordion-header.html,src%2Fapp%2Faccordion-header.ts:

  • Open the third panel
  • The button can be clicked
  • Click on the "Disable third" button on the second panel
  • The third panel's header is disabled, but the panel remains open, and the button can be clicked!

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 17.0.9

ng-bootstrap: 16.0.0

Bootstrap: 5.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant