Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing configuration for attribute role at NgbModal #4101

Open
cutiepiepony opened this issue May 25, 2021 · 1 comment · May be fixed by #4670
Open

missing configuration for attribute role at NgbModal #4101

cutiepiepony opened this issue May 25, 2021 · 1 comment · May be fixed by #4670
Labels
component: modal type: accessibility type: feature

Comments

@cutiepiepony
Copy link

feature request:

Using NgbModal for inserting a dialog offers no option to configure the value of the role attribute and is default "dialog".
It would be important considering WCAG to be able to set the value to "alertdialog" in certain cases.

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 11.2.9

ng-bootstrap: 9.1.0

Bootstrap: 4.6.0
@alexz01
Copy link

alexz01 commented Jul 13, 2023

Has this been fixed? I'm trying to create a session timeout alert modal and would like to use alertdialog role instead of the default dialog.

@danilopiazza danilopiazza linked a pull request Feb 1, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: modal type: accessibility type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(modal): add role option danilopiazza/ng-bootstrap
4 participants
@fbasso @maxokorokov @alexz01 @cutiepiepony