New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support the ng-package.json in secondary entry points #1406
fix: support the ng-package.json in secondary entry points #1406
Conversation
I as well wanted to add an addition to the documentation. Would it be fine like the example bellow?
### Alternative to `package.json`
Alternatively, you could create `ng-package.json` instead of `package.json`.
This is particularly useful in conjunction with `no-implicit-dependencies` TSLint rule, which will complain if `package.json` does not contain the dependencies used in the secondary entry point, which is misleading since all the dependencies should be mentioned in the primary `package.json`. |
@alan-agius4, how do you prefer in this projects for review adjustments to be applied? With additional commit or fixing the current commit? If we're squashing it anyway makes no difference, just wanna be sure. |
@klemenoslaj, doesn't make a difference :) |
Currently secondary entry points are breaking "no-implicit-dependencies" TSLint rule, because the rule is checking for package.json files, which in secondary entry points are anyway just containing "ngPackage" configuration. Adding the support for ng-package.json removes the need for package.json, thus TSLint will look correctly in parent package.json file and act accordingly. fix 1391
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks LGTM
This PR has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem. |
Currently secondary entry points are breaking
no-implicit-dependencies
TSLint rule, because therule is checking for package.json files, which in secondary entry points are anyway just containing
ngPackage
configuration. Adding the support for ng-package.json removes the need for package.json,thus TSLint will look correctly in parent package.json file and act accordingly.
fix 1391
I'm submitting a...
Checklist
Description
Fixes: 1391
Does this PR introduce a breaking change?