Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$secure_link_hmac_expires variable not filled #19

Open
SmaugPool opened this issue Sep 21, 2022 · 0 comments
Open

$secure_link_hmac_expires variable not filled #19

SmaugPool opened this issue Sep 21, 2022 · 0 comments

Comments

@SmaugPool
Copy link

SmaugPool commented Sep 21, 2022

During my tests, the $secure_link_hmac_expires variable value was overridden by the $secure_link_hmac_token one.

It might be due to the goto not_found when it is negative:

  228             if (expires < 0) {
  229                 goto not_found;
  230             }
  231 
  232             ctx = ngx_pcalloc(r->pool, sizeof(ngx_http_secure_link_ctx_t));
  233             if (ctx == NULL) {
  234                 return NGX_ERROR;
  235             }
  236 
  237             ngx_http_set_ctx(r, ctx, ngx_http_hmac_secure_link_module);
  238 
  239             ctx->expires.len = value.len;
  240             ctx->expires.data = value.data;

Or to the initialization issue fixed in this fork else:

area9innovation@6ac01a2

@SmaugPool SmaugPool changed the title $secure_link_hmac_expires variable not filled when negative $secure_link_hmac_expires variable not filled Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant