Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire vendoring #173

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Retire vendoring #173

merged 2 commits into from
Apr 8, 2021
+30 −252,894

Conversation

lucacome
Copy link
Contributor

@lucacome lucacome commented Apr 6, 2021

  • Removed vendor folder and modified CI/build process accordingly
  • Removed Go version from CI, reading the version from go.mod
  • While making these changes I noticed that we weren't using trimpath flag, so added that.

lucacome added 2 commits April 6, 2021 12:58
@lucacome
Remove vendor folder

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
27ab867
@lucacome
Remove vendor, add trimpath, remove version of Go from CI
4d3938f
@lucacome lucacome requested a review from a team April 6, 2021 20:03
@lucacome lucacome self-assigned this Apr 6, 2021
@lucacome lucacome requested review from ciarams87 and soneillf5 and removed request for a team April 6, 2021 20:03
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation labels Apr 6, 2021
@lucacome lucacome requested a review from pleshakov April 6, 2021 20:03
@lucacome
Copy link
Contributor Author

lucacome commented Apr 6, 2021

The removal of the folder is in a separate commit for readability, it will be squashed to one commit.

@lucacome lucacome removed the documentation Pull requests/issues for documentation label Apr 6, 2021
@lucacome lucacome changed the title Retire vendor folder Retire vendoring Apr 7, 2021
@lucacome lucacome enabled auto-merge (squash) April 7, 2021 23:37
@lucacome lucacome merged commit 872bc51 into master Apr 8, 2021
@lucacome lucacome deleted the chore/remove-vendor-folder branch April 8, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87

@soneillf5 soneillf5

@pleshakov pleshakov

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @ciarams87 @soneillf5