Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectator with jasmine 3.99.1: deprecation warnings #569

Open
levsim2016 opened this issue Jul 4, 2022 · 0 comments
Open

Spectator with jasmine 3.99.1: deprecation warnings #569

levsim2016 opened this issue Jul 4, 2022 · 0 comments

Comments

@levsim2016
Copy link

levsim2016 commented Jul 4, 2022

Is this a regression?

No

Description

  1. Update jasmine-core to 3.99.1 version
  2. Run npm install
  3. Try to run some test that uses spectator

After finishing these steps i get warning:
DEPRECATION: The matcher factory for "ɵ0" accepts custom equality testers, but this parameter will no longer be passed in a future release. See <https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#matchers-cet> for details.

It looks like when ngcc compiles spectator, it adds custom matchers and functions to customMatchers array:
image

As you can see ngcc added ɵ0, the reference to hasProperty function
image
image

So, it looks like functions are added to the array that should not be there (hasProperty, for example). When these functions added to customMatchers, jasmine tries to use them as custom matchers and fails.

Some tests written with spectator start failing after upgrading jasmine-core to 3.99.1

Any thoughts?

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

DEPRECATION: The matcher factory for "ɵ0" accepts custom equality testers, but this parameter will no longer be passed in a future release. See <https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#matchers-cet> for details.

Please provide the environment you discovered this bug in

jasmine-core v3.99.1
@ngneat/spectator v8.3.2
angular v12.2

Anything else?

No response

Do you want to create a pull request?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant