New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old .sock files are never deleted #14

Open

euank opened this issue Feb 28, 2019 · 0 comments

Collaborator

euank commented Feb 28, 2019

The coordination directory ends up littered with old .sock files.

They can still be listened on (as verified in the following test):

https://github.com/ngrok/tableroll/blob/e9b524f311b66e26ccf2e8b13601e08d19ff9072/upgrader_test.go#L166-L168

Because they're still re-usable, this is just a cosmetic issue, but it still looks a bit icky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment