You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
if nameOverride is set to "my-ingress" then ngrok-ingress-controller-my-ingress-manager-58d8dcbbf5-vlxp9 is then name
if fullnameOverride is to "my-ingress" then my-ingress-manager-5865d886d5-x582h is the name
if nothing is set set then default name of ngrok-ingress-controller-kubernetes-ingress-controller-manxzprm is used
@nijikokun the current naming scheme is undesirable to customers. I think it would be advantages to just drop the release.name from the default name all together. What do you think?
It seems like we are suggesting users to set release.name when installing other controllers leverage the --generate-name flag, we could leverage this.
Desired state would be getting the name down to ngrok-ingress-controller-[hash] without the additional kubernetes-ingress-controller part. Even if that means following other ingress controllers suit where they set the chart name to the company name from kubernetes-ingress-controller to ngrok.
This ideally would mean we wouldn't have to change the repository name as well.
What happened
The default pod name created by our helm chart is overly verbose and confusing. It should be shortned to be more clear and guessable.
What you think should happen instead
The current name is
ngrok-ingress-controller-kubernetes-ingress-controller-manager
for me because it combines the release name and the default name https://github.com/ngrok/kubernetes-ingress-controller/blob/main/helm/ingress-controller/templates/_helpers.tpl#L28Instead of using the regular name and the chart release name, we should just use the override if provided.
How to reproduce
install the chart and get the pods
This is related to #87 since the name is important for your ability to install multiple instances
The text was updated successfully, but these errors were encountered: