Skip to content

Commit bfe4c81

Browse files
alex-okrushkotimdeschryver
authored andcommittedNov 12, 2019
fix(effects): export CreateEffectMetadata (#2245)
Closes #2243
1 parent 90d0602 commit bfe4c81

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed
 

‎modules/effects/src/effect_creator.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { Observable } from 'rxjs';
22
import { Action } from '@ngrx/store';
3-
import { EffectMetadata, EffectConfig, DEFAULT_EFFECT_CONFIG } from './models';
4-
5-
const CREATE_EFFECT_METADATA_KEY = '__@ngrx/effects_create__';
6-
7-
interface CreateEffectMetadata {
8-
[CREATE_EFFECT_METADATA_KEY]: EffectConfig;
9-
}
3+
import {
4+
EffectMetadata,
5+
EffectConfig,
6+
DEFAULT_EFFECT_CONFIG,
7+
CreateEffectMetadata,
8+
CREATE_EFFECT_METADATA_KEY,
9+
} from './models';
1010

1111
type DispatchType<T> = T extends { dispatch: infer U } ? U : true;
1212
type ObservableType<T, OriginalType> = T extends false ? OriginalType : Action;

‎modules/effects/src/index.ts

+2-5
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,12 @@ export { EffectConfig } from './models';
33
export { Effect } from './effect_decorator';
44
export { getEffectsMetadata } from './effects_metadata';
55
export { mergeEffects } from './effects_resolver';
6-
export { EffectsMetadata } from './models';
6+
export { EffectsMetadata, CreateEffectMetadata } from './models';
77
export { Actions, ofType } from './actions';
88
export { EffectsModule } from './effects_module';
99
export { EffectSources } from './effect_sources';
1010
export { EffectNotification } from './effect_notification';
11-
export {
12-
ROOT_EFFECTS_INIT,
13-
rootEffectsInit,
14-
} from './effects_root_module';
11+
export { ROOT_EFFECTS_INIT, rootEffectsInit } from './effects_root_module';
1512
export { act } from './act';
1613
export {
1714
OnIdentifyEffects,

‎modules/effects/src/models.ts

+6
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,12 @@ export const DEFAULT_EFFECT_CONFIG: Readonly<Required<EffectConfig>> = {
1818
resubscribeOnError: true,
1919
};
2020

21+
export const CREATE_EFFECT_METADATA_KEY = '__@ngrx/effects_create__';
22+
23+
export interface CreateEffectMetadata {
24+
[CREATE_EFFECT_METADATA_KEY]: EffectConfig;
25+
}
26+
2127
export type EffectPropertyKey<T extends Object> = Exclude<
2228
keyof T,
2329
keyof Object

0 commit comments

Comments
 (0)
Please sign in to comment.