Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(signal): extends merged features results up to 25 #4315

Closed
wants to merge 5 commits into from
Closed

feat(signal): extends merged features results up to 25 #4315

wants to merge 5 commits into from

Conversation

SonyStone
Copy link

@SonyStone SonyStone commented May 7, 2024 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4314

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify Netlify
Copy link

netlify bot commented May 7, 2024 •
edited

✅ Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit b1f2c32
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6639f46fd3e0ab00085d1402

@brandonroberts
Copy link
Member

Let's discuss this in the issue first

@SonyStone
Copy link
Author

You could fix this issue now just by those add types, which has no breaking changes for curent users.

@SonyStone SonyStone mentioned this pull request May 7, 2024
Open
2 tasks
@markostanimirovic
Copy link
Member

You could fix this issue now just by those add types, which has no breaking changes for curent users.

Let's see. The question is - is this really an issue that should be fixed?

For example, Observable.pipe supports typing for up to 9 operators. If you have more than 9 operators in your chain, you're probably on the wrong way.

Before trying to find a solution or workaround for a problem that occurs in a system, we should first check if the system is properly designed. In other words, having a SignalStore with 20+ features is probably a wrong design choice, because that store does too many things and it could be very hard to maintain.

Anyway, adding additional signatures will be considered, but not 20+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Allow more than 10 signal store features
3 participants
@SonyStone @brandonroberts @markostanimirovic