Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng add @ngrx/eslint-plugin adds to dependencies instead of devDependencies #4322

Closed
1 of 2 tasks
Kombuchelada opened this issue May 8, 2024 · 0 comments · Fixed by #4343
Closed
1 of 2 tasks

ng add @ngrx/eslint-plugin adds to dependencies instead of devDependencies #4322

Kombuchelada opened this issue May 8, 2024 · 0 comments · Fixed by #4343

Comments

@Kombuchelada
Copy link

Which @ngrx/* package(s) are the source of the bug?

eslint-plugin

Minimal reproduction of the bug/regression with instructions

run ng add @ngrx/eslint-plugin in an existing angular project

Expected behavior

the @ngrx/eslint-plugin is added to the "devDependencies" section of the package.json

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)

NgRx: 17.2.0
Angular: 17.3.7
Node: 21.7.1
OS: Windows (powershell)

Other information

Here's the output of running that schematic on a fresh angular project, showing it is added to the "dependencies" section and not the "devDependencies" section:

PS C:\Users\*****\temp\test\test> ng add @ngrx/eslint-plugin
Node.js version v21.7.1 detected.
Odd numbered Node.js versions will not enter LTS status and should not be used for production. For more information, please see https://nodejs.org/en/about/previous-releases/.
ℹ Using package manager: npm
✔ Found compatible package version: @ngrx/eslint-plugin@17.2.0.
✔ Package information loaded.

The package @ngrx/eslint-plugin@17.2.0 will be installed and executed.
Would you like to proceed? Yes
✔ Packages successfully installed.
? Which ESLint configuration would you like to use? recommended

    Could not find the ESLint config at `.eslintrc.json`.
    The NgRx ESLint Plugin is installed but not configured.

    Please see https://ngrx.io/guide/eslint-plugin to configure the NgRx ESLint Plugin.

Nothing to be done.
PS C:\Users\*****\temp\test\test> type package.json
{
  "name": "test",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "watch": "ng build --watch --configuration development",
    "test": "ng test"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^17.3.0",
    "@angular/common": "^17.3.0",
    "@angular/compiler": "^17.3.0",
    "@angular/core": "^17.3.0",
    "@angular/forms": "^17.3.0",
    "@angular/platform-browser": "^17.3.0",
    "@angular/platform-browser-dynamic": "^17.3.0",
    "@angular/router": "^17.3.0",
    "@ngrx/eslint-plugin": "^17.2.0",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "~0.14.3"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^17.3.2",
    "@angular/cli": "^17.3.2",
    "@angular/compiler-cli": "^17.3.0",
    "@types/jasmine": "~5.1.0",
    "jasmine-core": "~5.1.0",
    "karma": "~6.4.0",
    "karma-chrome-launcher": "~3.2.0",
    "karma-coverage": "~2.2.0",
    "karma-jasmine": "~5.1.0",
    "karma-jasmine-html-reporter": "~2.1.0",
    "typescript": "~5.4.2"
  }
}

I would be willing to submit a PR to fix this issue

  • Yes
  • No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant