Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSDoc for mapResponse operator #4336

Closed
1 of 2 tasks
markostanimirovic opened this issue May 13, 2024 · 1 comment · Fixed by #4337
Closed
1 of 2 tasks

Add JSDoc for mapResponse operator #4336

markostanimirovic opened this issue May 13, 2024 · 1 comment · Fixed by #4337
Labels
Accepting PRs Comp: Docs

Comments

@markostanimirovic
Copy link
Member

Information

Add JSDoc including description and usage notes for the mapResponse operator.

It should be done in the same format as JSDoc for tapResponse: https://github.com/ngrx/platform/blob/main/modules/operators/src/tap-response.ts#L20

Documentation page

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@markostanimirovic markostanimirovic mentioned this issue May 13, 2024
Merged
3 tasks
@rainerhahnekamp rainerhahnekamp mentioned this issue May 14, 2024
Merged
3 tasks
@rainerhahnekamp
Copy link
Contributor

I have provided a PR. What about JSDoc for the Signal Store?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Comp: Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(operators): add JSDoc for mapResponse rainerhahnekamp/ngrx
2 participants
@rainerhahnekamp @markostanimirovic