Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent build failures with TS 4.6.4 #709

Closed
TrevorKarjanis opened this issue Sep 1, 2022 · 2 comments
Closed

Intermittent build failures with TS 4.6.4 #709

TrevorKarjanis opened this issue Sep 1, 2022 · 2 comments
Labels
blocked Blocked on a third-party issue bug Something isn't working

Comments

@TrevorKarjanis
Copy link
Contributor

馃悰 Bug Report

The nimble-components and nimble-angular builds fail intermittently with TS 4.6.4.

馃捇 Repro or Code Sample

  1. Pull the angular-14 branch.
  2. Run npm install.
  3. Run npm install --no-save typescript@4.6.4.
  4. Run npm run build.

馃 Expected Behavior

The build should pass.

馃槸 Current Behavior

@microsoft/fast-foundation fails the library checks (example)

Error: ../../node_modules/@microsoft/fast-foundation/dist/fast-foundation.d.ts(2252,66): error TS2344: Type 'T' does not satisfy the constraint 'string | number | boolean | symbol | any[] | Uint8Array | ({ createCSS?(): string; } & Record<PropertyKey, any>) | null'.
  Type 'T' is not assignable to type '{ createCSS?(): string; } & Record<PropertyKey, any>'.
    Type 'T' is not assignable to type '{ createCSS?(): string; }'.
Error: ../../node_modules/@microsoft/fast-foundation/dist/fast-foundation.d.ts(2254,186): error TS2344: Type 'T' does not satisfy the constraint 'string | number | boolean | symbol | any[] | Uint8Array | ({ createCSS?(): string; } & Record<PropertyKey, any>) | null'.
  Type 'T' is not assignable to type '{ createCSS?(): string; } & Record<PropertyKey, any>'.
    Type 'T' is not assignable to type '{ createCSS?(): string; }'.
Error: ../../node_modules/@microsoft/fast-foundation/dist/fast-foundation.d.ts(2256,121): error TS2344: Type 'T' does not satisfy the constraint 'string | number | boolean | symbol | {} | any[] | Uint8Array | null'.

馃拋 Possible Solution

Pin the version declared by @microsoft/fast-foundation, 4.6.2 (example).

馃敠 Context

Upgrading Angular and ESLint upgrades TS.

馃實 Your Environment

  • OS & Device: Windows
  • Version: nimble-angular@8.4.7
@TrevorKarjanis TrevorKarjanis added bug Something isn't working triage New issue that needs to be reviewed labels Sep 1, 2022
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Sep 7, 2022
@TrevorKarjanis
Copy link
Contributor Author

This is also fast-foundaton issue 6365.

@jattasNI jattasNI added the blocked Blocked on a third-party issue label Dec 2, 2022
@rajsite
Copy link
Member

rajsite commented Feb 1, 2023

With the #1000 update all of our packages (except one build tool) are resolving to TS 4.6.4 and the version in the root was removed. I have not seen intermittent build failures since the Angular 14 upgrade or issues regenerating the lockfile.

So as described I think this bug is resolved. We do need to still get TS 4.8 working and I'll repurpose #810 for that

@rajsite rajsite closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on a third-party issue bug Something isn't working
Projects
Development

No branches or pull requests

4 participants