Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

@mdx-js/react fails to install #806

Closed
TrevorKarjanis opened this issue Nov 9, 2022 · 1 comment
Closed

@mdx-js/react fails to install #806

TrevorKarjanis opened this issue Nov 9, 2022 · 1 comment

Comments

@TrevorKarjanis
Copy link
Contributor

TrevorKarjanis commented Nov 9, 2022

馃Ч Tech Debt

@mdx-js/react is a dependency of @storybook/addon-docs, but it doesn't always get installed. This causes the nimble-components build to fail. #708 declares it as a dependency to resolve the issue. Jesse suggests the issue be investigated further. Storybook issue 18094 may be related.

@TrevorKarjanis TrevorKarjanis added tech debt triage New issue that needs to be reviewed labels Nov 9, 2022
@TrevorKarjanis TrevorKarjanis mentioned this issue Nov 9, 2022
1 task
@jattasNI jattasNI removed the triage New issue that needs to be reviewed label Nov 15, 2022
@rajsite
Copy link
Member

rajsite commented Feb 1, 2023

This was resolved by #1000 by migrating to mdx2 experimental support in Storybook 6.4.

The "surprsing" explicit dependency on mdx-js/react is still needed but we no longer have runtime errors in storybook about mdx/react support which was the state after the Angular update. And after #1000 we no longer after peer dependency version conflicts due to mdx-js/react when rebuilding the lock file.

After Storybook 7 is released there will be a significant change (mdx2 is the default and builder switches to vite) so any extra clean-up will happen then. I think this issue is fine to close till then.

@rajsite rajsite closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants