Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please revert to allow example namespace #24

Open
jonassmedegaard opened this issue Feb 21, 2019 · 8 comments
Open

please revert to allow example namespace #24

jonassmedegaard opened this issue Feb 21, 2019 · 8 comments

Comments

@jonassmedegaard
Copy link

e9fe1e5 causes failures in several modules - quite likely the very same that Kjetil had special concern about: https://bugs.debian.org/922878

I will now revert that change for Debian, and suggest you consider doing the same upstream.

@kjetilk
Copy link
Contributor

kjetilk commented Feb 21, 2019

I suggest holding on for a bit, I remember having some very confusing issues around this, but I don't remember what it was.

@kjetilk
Copy link
Contributor

kjetilk commented Feb 21, 2019

Ah, found it, it was #21.

@kjetilk
Copy link
Contributor

kjetilk commented Feb 21, 2019

What happened here was that people would vote up certain prefixes on prefix.cc, and if you have e.g. http://example.org/ in tests that use URI::NamespaceMap's guessing code (which is a nice feature, saves you a lot of typing), tests will break in unpredictable ways due to crowdsourcing beyond your control, and depending on what modules are installed on the testing system.

I still don't see a good reason why you'd want crowdsourced prefixes for URIs that include the reserved domains, the low number of votes is likely to make this much more unstable than the more popular namespaces.

I can see several ways to fix this, one is to not have integration tests in upstream modules use the guessing code of URI::NamespaceMap. That would likely lower the total coverage. One is to invent totally random URIs for the tests that now use http://example.org (and friends). That would make the tests less readable, I think. One is to always enter those explicitly to the URI::NamespaceMap constructor, but that would make for more typing.

@jonassmedegaard
Copy link
Author

a) Your patch is not limited to IANA reserved domains, but suppresses any domain containing "example".

b) Relying on Internet resources essentially is crowdsourcing ;-)

c) If you want non-surprising lists, then either fixate on a specific date, or use RDF::NS::Curated.

d) I still miss information about what actually breaks when using domains containing "example" compared to domains containing e.g. "foobar". I raised that question in #21 as well.

@kjetilk
Copy link
Contributor

kjetilk commented Feb 21, 2019

Long story short (since I spent too much time already): I don't think this should be reverted, as it solved a real problem. It is not ideal, so, I think rather than revert, improve.

@nichtich
Copy link
Owner

nichtich commented Feb 22, 2019 via email

@kjetilk
Copy link
Contributor

kjetilk commented Feb 22, 2019

Yes, that would work for me.

@nichtich
Copy link
Owner

I've released 20190227 with the exclusion of example.* TLD removed but their current prefixes have been locked from future updates as set in version 20170111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants