Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned dependency, request@2.69.0 is broken #133

Closed
pwfisher opened this issue Jul 12, 2016 · 4 comments
Closed

Pinned dependency, request@2.69.0 is broken #133

pwfisher opened this issue Jul 12, 2016 · 4 comments

Comments

@pwfisher
Copy link

request/request#2040
@seangenabe
Copy link

request@2.69.0 -> tough-cookie@2.2.2 is not secure. https://nodesecurity.io/advisories/130

@SimenB
Copy link

SimenB commented Nov 19, 2016

It's on 2.75 now.

The current one has a deprecation warning from request though, would be nice with another bump

@busches
Copy link

busches commented Nov 22, 2016 •
edited

New warning is request > node-uuid@1.4.7: use uuid module instead. This is fixed in request v2.79.0, but request v2.77.0 dropped support for all versions of node <4 which would be a breaking change for this project. The same PR that was filed against request could and probably should be filed against here.

I'd be happy to open a PR to upgrade to Node v4 and fix the dependency issue.

@pmuens
Copy link

pmuens commented Dec 5, 2016

Facing the same issue. 👍 for the version bump so that the new request package with uuid support is used.

@pmuens pmuens mentioned this issue Dec 5, 2016
Closed
mdlavin added a commit to mdlavin/node-coveralls that referenced this issue Sep 28, 2017
@mdlavin
Expand allowed dependency versions to all API compatible versions
c2cd266 
Fixes nickmerwin#171
Fixes nickmerwin#170
Fixes nickmerwin#153
Fixes nickmerwin#149
Fixes nickmerwin#133
@mdlavin mdlavin mentioned this issue Sep 28, 2017
Merged
nickmerwin pushed a commit that referenced this issue Sep 28, 2017
@mdlavin @nickmerwin
Expand allowed dependency versions to all API compatible versions (#172)
428780c 
Fixes #171
Fixes #170
Fixes #153
Fixes #149
Fixes #133
@fguitton fguitton mentioned this issue Oct 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pwfisher @busches @SimenB @pmuens @seangenabe