Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue json-schema #327

Open
dalisoft opened this issue Feb 26, 2022 · 4 comments
Open

Security issue json-schema #327

dalisoft opened this issue Feb 26, 2022 · 4 comments

Comments

@dalisoft
Copy link

Hello @nickmerwin and node-coveralls team

Thank you a lot for maintaining this great package. I got notification which json-schema is vulnerable and when running yarn why json-schema i found these result

yarn why v1.22.17
[1/4] 🤔  Why do we have the module "json-schema"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "json-schema@0.2.3"
info Reasons this module exists
   - "coveralls#request#http-signature#jsprim" depends on it
   - Hoisted from "coveralls#request#http-signature#jsprim#json-schema"
info Disk size without dependencies: "256KB"
info Disk size with unique dependencies: "256KB"
info Disk size with transitive dependencies: "256KB"
info Number of shared dependencies: 0
✨  Done in 0.39s.

We can somehow fix this?

@jtwebman
Copy link

jtwebman commented Mar 6, 2022

Since this library doesn't seem to be supported anymore I fix a bunch of things on a fork if you want to check it out and are still pulling the library into your packages: https://github.com/jtwebman/coveralls-next

@ain
Copy link

ain commented May 9, 2022

@jtwebman why don't you send a PR from your fork against the main repo so it can be considered for an official release?

@jtwebman
Copy link

@ain I had one open for over a year and never got merged. #311

@dalisoft
Copy link
Author

dalisoft commented Sep 1, 2022

As we waited so long and i'm decided to go with coveralls-next
Thank you @jtwebman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants