From 24fa3c9f68a232fd0d78a96cb8e01d9a422d515e Mon Sep 17 00:00:00 2001 From: nidkil Date: Fri, 14 Dec 2018 11:43:34 +0100 Subject: [PATCH 1/3] Userfriendly warning if COVERALLS_REPO_TOKEN is not set --- lib/getOptions.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/getOptions.js b/lib/getOptions.js index 0c2c7dc3..e350e506 100644 --- a/lib/getOptions.js +++ b/lib/getOptions.js @@ -147,8 +147,10 @@ var getBaseOptions = function(cb){ } } } catch(ex){ - logger.warn("Repo token could not be determined. Continuing without it." + - "This is necessary for private repos only, so may not be an issue at all."); + const msg = "Repo token (COVERALLS_REPO_TOKEN) could not be determined. Continuing without it. " + + "The token is necessary for private repos only, so may not be an issue." + logger.warn('WARNING: ' + msg); + (!process.env.COVERALLS_QUIETE || process.env.COVERALLS_QUIETE === false) && console.warn(msg); } } From 666cfb36c8486103fc8453617675e3d88c62dc44 Mon Sep 17 00:00:00 2001 From: nidkil Date: Fri, 14 Dec 2018 11:50:42 +0100 Subject: [PATCH 2/3] Corrected warning --- lib/getOptions.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/getOptions.js b/lib/getOptions.js index e350e506..0651be03 100644 --- a/lib/getOptions.js +++ b/lib/getOptions.js @@ -148,9 +148,9 @@ var getBaseOptions = function(cb){ } } catch(ex){ const msg = "Repo token (COVERALLS_REPO_TOKEN) could not be determined. Continuing without it. " + - "The token is necessary for private repos only, so may not be an issue." - logger.warn('WARNING: ' + msg); - (!process.env.COVERALLS_QUIETE || process.env.COVERALLS_QUIETE === false) && console.warn(msg); + "The token is necessary for private repos only, so it may not be an issue." + logger.warn(msg); + (!process.env.COVERALLS_QUIETE || process.env.COVERALLS_QUIETE === false) && console.warn('WARNING: ' + msg); } } From 231270d939220d38e00c4be115952e3b3343f81a Mon Sep 17 00:00:00 2001 From: nidkil Date: Fri, 14 Dec 2018 12:12:57 +0100 Subject: [PATCH 3/3] Changed warning message to be actionable --- lib/getOptions.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/getOptions.js b/lib/getOptions.js index 0651be03..8c8eb45f 100644 --- a/lib/getOptions.js +++ b/lib/getOptions.js @@ -147,10 +147,9 @@ var getBaseOptions = function(cb){ } } } catch(ex){ - const msg = "Repo token (COVERALLS_REPO_TOKEN) could not be determined. Continuing without it. " + - "The token is necessary for private repos only, so it may not be an issue." + const msg = "Repo token (COVERALLS_REPO_TOKEN) not found, continuing without it. If an error occurs try setting it." logger.warn(msg); - (!process.env.COVERALLS_QUIETE || process.env.COVERALLS_QUIETE === false) && console.warn('WARNING: ' + msg); + (!process.env.COVERALLS_QUIETE || process.env.COVERALLS_QUIETE === '0') && console.warn('WARNING: ' + msg); } }