Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some attributes should accept boolean values #19

Open
ratorx opened this issue Sep 6, 2020 · 2 comments
Open

Some attributes should accept boolean values #19

ratorx opened this issue Sep 6, 2020 · 2 comments

Comments

@ratorx
Copy link

ratorx commented Sep 6, 2020

Some attributes are incorrectly marked as taking a string, whereas they should take boolean values.

As a concrete example, HtmlScriptTag.defer should take a boolean argument, rather than a string argument.

@bebraw
Copy link
Contributor

bebraw commented Sep 8, 2020

Can you compile a list? Is there a definitive source for these? Would it be possible to consume the correct types from some another type definition for the DOM?

@ratorx
Copy link
Author

ratorx commented Sep 8, 2020

Typescript has a list of generated DOM types as well as the source code for the generator available.

This seems like a good source of definitive APIs for this project. Perhaps a wrapper to the generator could be used to generate the specific type definitions needed by this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants