-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing summary tag #40
Comments
Hey @believer, I'm maintaining a fork (https://github.com/kitajs/html) which already has This library seems to be unmaintained, (no license, #23, no fragment support...) I'm maintaining @kitajs/html with some extra features I wanted to add, like fragments, more performant, a pre-compiled mode, null/undefined handling, preact ( I'm open to creating a PR to this repo if requested. |
@arthurfiorette Hey! Thanks for creating your fork, it works great. I had to adjust the getting started steps slightly to get it working (it might be because I'm using Bun?). The steps are similar to the getting started steps in // tsconfig.json
{
"compilerOptions": {
"jsx": "react",
"jsxFactory": "elements.createElement"
}
}
// Use in file
import * as elements from '@kitajs/html' |
@believer thanks for your heads up! Things should now be fixed at P.S: I think you should now be able to go back to the README setup, as the example above will not works with fragments :) |
@arthurfiorette Thanks for the quick update, but I still can't get it to work. If I only use My entire {
"compilerOptions": {
"lib": ["ESNext"],
"module": "esnext",
"target": "esnext",
"moduleResolution": "bundler",
"moduleDetection": "force",
"allowImportingTsExtensions": true,
"strict": true,
"downlevelIteration": true,
"skipLibCheck": true,
"jsx": "react",
"reactNamespace": "html",
"allowSyntheticDefaultImports": true,
"forceConsistentCasingInFileNames": true,
"allowJs": true,
"noEmit": true,
"types": [
"bun-types" // add Bun global
]
}
} Maybe there's some other option here that's conflicting? Edit: Ok, it worked with:
But not if I call it |
The
summary
tag seems to be missing in the intrinsic elements' definition. This is used together withdetails
, which does exist in the definitions.I can create a PR if the issue is valid. I think there's only a
summary: HtmlTag;
missing, since thesummary
tag only includes the global attributes.Thanks for a great library!
The text was updated successfully, but these errors were encountered: