Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nicolasbeauvais/vue-social-sharing
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.4.6
Choose a base ref
...
head repository: nicolasbeauvais/vue-social-sharing
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.4.7
Choose a head ref
  • 3 commits
  • 8 files changed
  • 3 contributors

Commits on Nov 5, 2019

  1. #156 Don't stop the console error when closed Popup.

    @jf-m
    jf-m committed Nov 5, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    heifner Kevin Heifner
    GPG key ID: 2C1338A8B4D672C5
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e88528c View commit details

Commits on Nov 7, 2019

  1. Merge pull request #171 from jf-m/fix/156 

    Fix issue #156 Don't stop the console error when closed Popup.
    @nicolasbeauvais
    nicolasbeauvais authored Nov 7, 2019
    Copy the full SHA
    fbed287 View commit details

  2. Fix undefined popup error

    Nicolas Beauvais committed Nov 7, 2019
    Copy the full SHA
    17d26cc View commit details
Showing with 16 additions and 12 deletions.
  1. +4 −0 CHANGELOG.md
  2. +1 −1 bower.json
  3. +3 −3 dist/vue-social-sharing.common.js
  4. +3 −3 dist/vue-social-sharing.js
  5. +2 −2 dist/vue-social-sharing.min.js
  6. +1 −1 package.json
  7. +1 −1 src/index.js
  8. +1 −1 src/social-sharing.js
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
<a name="2.4.7"></a>
# [2.4.7](https://github.com/nicolasbeauvais/vue-social-sharing/compare/2.4.6...2.4.7) (2019-11-07)
- Fix undefined popup error

<a name="2.4.6"></a>
# [2.4.6](https://github.com/nicolasbeauvais/vue-social-sharing/compare/2.4.5...2.4.6) (2019-08-11)
- Fix IOS Twitter sharing with empty hashtags, again
2 changes: 1 addition & 1 deletion bower.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vue-social-sharing",
"version": "2.4.6",
"version": "2.4.7",
"homepage": "https://github.com/nicolasbeauvais/vue-social-sharing",
"authors": [
"nicolasbeauvais <nicolasbeauvais1@gmail.com>"
6 changes: 3 additions & 3 deletions dist/vue-social-sharing.common.js
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* vue-social-sharing v2.4.6
* vue-social-sharing v2.4.7
* (c) 2019 nicolasbeauvais
* Released under the MIT License.
*/
@@ -340,7 +340,7 @@ var SocialSharing = {

// Create an interval to detect popup closing event
this.popup.interval = setInterval(function () {
if (popupWindow.closed) {
if (!popupWindow || popupWindow.closed) {
clearInterval(this$1.popup.interval);

popupWindow = undefined;
@@ -389,7 +389,7 @@ var SocialSharing = {
}
};

SocialSharing.version = '2.4.6';
SocialSharing.version = '2.4.7';

SocialSharing.install = function (Vue) {
Vue.component('social-sharing', SocialSharing);
6 changes: 3 additions & 3 deletions dist/vue-social-sharing.js
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* vue-social-sharing v2.4.6
* vue-social-sharing v2.4.7
* (c) 2019 nicolasbeauvais
* Released under the MIT License.
*/
@@ -342,7 +342,7 @@ var SocialSharing = {

// Create an interval to detect popup closing event
this.popup.interval = setInterval(function () {
if (popupWindow.closed) {
if (!popupWindow || popupWindow.closed) {
clearInterval(this$1.popup.interval);

popupWindow = undefined;
@@ -391,7 +391,7 @@ var SocialSharing = {
}
};

SocialSharing.version = '2.4.6';
SocialSharing.version = '2.4.7';

SocialSharing.install = function (Vue) {
Vue.component('social-sharing', SocialSharing);
4 changes: 2 additions & 2 deletions dist/vue-social-sharing.min.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vue-social-sharing",
"description": "A Vue.js component for sharing links to social networks",
"version": "2.4.6",
"version": "2.4.7",
"author": {
"name": "nicolasbeauvais",
"email": "nicolasbeauvais1@gmail.com"
2 changes: 1 addition & 1 deletion src/index.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import SocialSharing from './social-sharing';

SocialSharing.version = '2.4.6';
SocialSharing.version = '2.4.7';

SocialSharing.install = (Vue) => {
Vue.component('social-sharing', SocialSharing);
2 changes: 1 addition & 1 deletion src/social-sharing.js
View file
Original file line number Diff line number Diff line change
@@ -257,7 +257,7 @@ export default {

// Create an interval to detect popup closing event
this.popup.interval = setInterval(() => {
if (popupWindow.closed) {
if (!popupWindow || popupWindow.closed) {
clearInterval(this.popup.interval);

popupWindow = undefined;