Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make re2 an optional peer dependency #24

Merged
merged 1 commit into from Jan 3, 2022
Merged

Make re2 an optional peer dependency #24

merged 1 commit into from Jan 3, 2022

Conversation

KevinNovak
Copy link
Contributor

@KevinNovak KevinNovak commented Dec 7, 2021 •
edited

Address issue #23. This is basically Option 1 in #18.

@KevinNovak
Copy link
Contributor Author

KevinNovak commented Dec 7, 2021 •
edited

Looks like some of the scripts, like the "test-coverage" script run by the CI, requires re2 to be installed. Not sure the best action to take here. Should we require re2 for tests but not for the overall package?

@niftylettuce
Copy link
Collaborator

Add re2 to devDependencies

@niftylettuce niftylettuce merged commit a050a90 into spamscanner:master Jan 3, 2022
@niftylettuce
Copy link
Collaborator

I'll manually add it and version bump and fix lockfile.

@niftylettuce
Copy link
Collaborator

See v3.0.0 https://github.com/spamscanner/url-regex-safe/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KevinNovak @niftylettuce