Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14 destructured objects #15

Closed
wants to merge 6 commits into from

Conversation

basejump
Copy link

@basejump basejump commented May 28, 2022

WIP
Closes #14

@basejump basejump marked this pull request as draft May 28, 2022 16:51
@basejump basejump marked this pull request as ready for review May 28, 2022 20:57
@nikku
Copy link
Owner

nikku commented Jun 6, 2022

Thanks for your PR. As I've commented I think this is something worth supporting if the bundle size increase is manageable.


However, I'd ask you do a couple of things:

  • Do not separate existing and new tests (what is the benefit)?
  • Clearly and thoroughly test different cases
    • Semantics of mixed $inject and destructuring logic
    • Nested destructuring
  • Cover default values
  • Do not mix general documentation improvements and object destructuring
  • Works for all standard destructuring cases (including newlines, default values, argument renaming). I believe without that the implementation is too fragile to be merged.

@nikku nikku closed this Nov 22, 2023
@nikku
Copy link
Owner

nikku commented Nov 22, 2023

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destructured Function Parameter Injection
2 participants