Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork the project #3172

Open
Zefling opened this issue May 8, 2024 · 10 comments
Open

Fork the project #3172

Zefling opened this issue May 8, 2024 · 10 comments

Comments

@Zefling
Copy link

Zefling commented May 8, 2024

As the project is no longer moving, I forked the project to make it a more open project. If you want to help me to become a maintainer on it, please contact me.

git : https://github.com/html2canvas/html2canvas
npm : https://www.npmjs.com/package/@html2canvas/html2canvas

I also merged 2 branches that had started doing this for personal needs.
Thanks @acurrieclark and @wtto00

@SRochas
Copy link

SRochas commented May 9, 2024

Excited to see a fork of this! I'm personally trying to use some React screenshot-taking libraries that are all based off of html2canvas. html2canvas seems to have issues with React17+ with the screenshot appearing distorted. (Here's the SO for additional context).

Do you have any plans with what you'd like to do with the library? I'd love to see a fix to these issues.

@AgentSmith0
Copy link

@Zefling Very cool, thank you for your work! What about enabling the issues and discussions tab?

@Zefling
Copy link
Author

Zefling commented May 11, 2024

Oops, sorry, it's fixed. I activated the issues.

@nocarroll-v8m
Copy link

Hi @Zefling , very cool to see a fork of this project.

Is performance improvement part of the scope of your fork?

I am seeing some heavy memory usage in DocumentCloner.cloneNode and I am curious if it is something you are looking to address?

Thanks!

@dionysiusmarquis
Copy link

dionysiusmarquis commented May 18, 2024

The approach of html-to-image seems a bit like a successor to html2canvas to me. What are use cases exclusively for the approach of html2canvas?

@cyfung1031
Copy link

cyfung1031 commented May 23, 2024

The approach of html-to-image seems a bit like a successor to html2canvas to me. What are use cases exclusively for the approach of html2canvas?

The author of html2canvas has paid a lot of effort to resolve many minor issues (e.g. CSS and transform work) on the image generation.

Any case that html-to-image is better?

@cyfung1031
Copy link

cyfung1031 commented May 23, 2024

@Zefling
https://github.com/html2canvas/html2canvas/blob/master/CHANGELOG.md
Why the changes mentioned in 1.5.x are already merged into the niklasvh/html2canvas before 1.5.x released?

@Zefling
Copy link
Author

Zefling commented May 23, 2024

@cyfung1031 I copied the changelog from the branch. I'm going to take the 1.5.x changelog, it's a bit of a mess.

Haven't had much time to take care of it lately. Basically, I made this version because I needed what was in it and it wasn't easy to have projects maintained by only one person.

I insist, I did the project precisely so that there is not a single maintainer. If you want to help, just ask me.

@dionysiusmarquis
Copy link

The author of html2canvas has paid a lot of effort to resolve many minor issues (e.g. CSS and transform work) on the image generation.

Any case that html-to-image is better?

html-to-image utilises svg rendering. It basically uses the exact same way the browser renders everything. Therefore it’s possible to get pixel perfect renders of html elements in any state.

I didn’t necessarily try to say html-to-image is “better”. It just feels like a simpler/slimmer approach with more accurate results. But maybe html2canvas is faster or fits better in other fields, so it’s worth to pursue this approach? That’s what my question was aiming at.

@cyfung1031
Copy link

@cyfung1031 I copied the changelog from the branch. I'm going to take the 1.5.x changelog, it's a bit of a mess.

Haven't had much time to take care of it lately. Basically, I made this version because I needed what was in it and it wasn't easy to have projects maintained by only one person.

I insist, I did the project precisely so that there is not a single maintainer. If you want to help, just ask me.

Um. I just want to know what are the changes added in the forked repo, compared to the 1.4.1 released in 2022.01.23
If those changes are already merged into niklasvh/html2canvas, those changes should have been incorporated in 1.4.1 right?

Just want to clarify what are the new in the forked repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants