Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): Add GMail service #417

Open
irfansofyana opened this issue Oct 8, 2022 · 6 comments
Open

feat(service): Add GMail service #417

irfansofyana opened this issue Oct 8, 2022 · 6 comments
Labels
affects/services Issue or PR related to a notification service. good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed type/feature New feature or request up for grabs

Comments

@irfansofyana
Copy link
Contributor

Describe the missing service. Please provide useful links.

Gmail is one of the mail providers that is used by many people. I think adding a Gmail service to notify will attract people to use more this library.

It will be possible to implement because GMail has an API to interact. See more details: https://developers.google.com/gmail/api/quickstart/go

Describe the solution you'd like

  • Add new service to send a notification via email using Gmail API

Potential libraries to use

@irfansofyana irfansofyana added affects/services Issue or PR related to a notification service. good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed type/feature New feature or request up for grabs labels Oct 8, 2022
@irfansofyana
Copy link
Contributor Author

Hi @nikoksr I can try to help working on this too if you're okay with it :)

@nikoksr
Copy link
Owner

nikoksr commented Oct 10, 2022

@irfansofyana thanks for bringing in your ideas! We appreciate it alot. However, I feel like, I'm failing to see the additional benefit that gmail would bring to the project over the existing mail service. Maybe you could elaborate before we continue.

@irfansofyana
Copy link
Contributor Author

thank you @nikoksr,

In my opinion, creating a Gmail service is a benefit for some parties that don't want to host an SMTP server and want a free service.

As I could see right now, in the mail service we would need some SMTP configuration.

I also can see that we have SendGrid but at some point, it's a paid service. Gmail service in my opinion will be a good deal because people don't need to set up the SMTP server by themselves and it's completely free.

@nikoksr
Copy link
Owner

nikoksr commented Oct 10, 2022

@irfansofyana am I missing something or couldn't we simply use GMail as the SMTP server in our existing mail service? There's docs for it too. I mean, sure, like you said, there would be some configuration necessary but that's true for basically all services.

Don't get me wrong, I'm all for new services and widening Notify's spectrum but I also want to make sure that the list doesn't get unecessarily bloated. I still appreciate your input, but you have to understand that I need to be considerate about it, too.

One thing I could think of, even though not sure how I feel about it yet, would be to basically add a Gmail service using the existing mail service. So, we'd basically take away the effort of looking up those config values by yourself, while sticking with our existing service.

I'm not entirely against this but we should take our time and really think about the risk(pain)/reward ratio here.

@irfansofyana
Copy link
Contributor Author

am I missing something or couldn't we simply use GMail as the SMTP server in our existing mail service? There's docs for it too.

ah I see, I don't know about this and missed this previously! I think we will need to check further if it's possible or not but I think it will be possible.

Don't get me wrong, I'm all for new services and widening Notify's spectrum but I also want to make sure that the list doesn't get unnecessarily bloated. I still appreciate your input, but you have to understand that I need to be considerate about it, too.

No worries about this, I fully agree with your point here!

@irfansofyana
Copy link
Contributor Author

feel free to close this issue if you feel it's necessary, @nikoksr thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/services Issue or PR related to a notification service. good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed type/feature New feature or request up for grabs
Projects
None yet
Development

No branches or pull requests

2 participants