Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipes-archive-melpa: fix incorrect source hashes #401

Merged
merged 2 commits into from
May 18, 2024

Conversation

jian-lin
Copy link
Contributor

@jian-lin jian-lin commented May 6, 2024

maybe close #391

This is basically NixOS/nixpkgs#309270 with
two fixes excluded.

The fix for smartparens is excluded because it has already been
fixed[1] here.

The fix for flycheck-cfn is also excluded because it has been bumped
to 20240512.2341 in 4fe6cc3.
However, the new hash is still incorrect.  Its fix is in the next
commit.

[1]: nix-community#400
@jian-lin
Copy link
Contributor Author

This PR contains two commits.

One is basically NixOS/nixpkgs#309270 with two fixes excluded, which fixes incorrect source hashes in both Nixpkgs and this overlay. This commit can be reviewed in an easy way:

  1. search emacsPackages before recipes-archive-melpa: fix incorrect source hashes NixOS/nixpkgs#309270 is merged here and find that there are many failures on x86_64-linux due to source error
  2. search emacsPackages after recipes-archive-melpa: fix incorrect source hashes NixOS/nixpkgs#309270 is merged here and find that there is no failure on x86_64-linux due to source error

Another commit fixes three incorrect source hashes specific to this overlay. Since there are only three changed hashes, it is not hard to review this.

Could we merge this soon so that I do not have to resolve more merge conflicts caused by auto update? @adisbladis @leungbk

@leungbk leungbk merged commit 856376d into nix-community:master May 18, 2024
1 check passed
@leungbk
Copy link
Member

leungbk commented May 18, 2024

Thanks, and I'm sorry for not merging sooner.

@jian-lin jian-lin deleted the pr/fix-source-hash branch May 18, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect (?) hashes for sources in latest emacs-overlay
2 participants