Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider inverting "release" and "latest" #45

Open
yangm97 opened this issue Sep 2, 2023 · 3 comments
Open

Consider inverting "release" and "latest" #45

yangm97 opened this issue Sep 2, 2023 · 3 comments

Comments

@yangm97
Copy link

yangm97 commented Sep 2, 2023

Currently only a hand-craft set of extensions are fetched using their release versions, while everything else defaults to (almost always) preview releases. While this wouldn't be a proper fix for #41 it would improve the likelihood of finding a commit of this repo containing stable compatible extensions.

@AmeerTaweel
Copy link
Collaborator

Last week I wanted to install ms-vscode-remote.remote-ssh (Remote - SSH). Both release and latest versions were incompatible with VSCode from nixos-unstable. So as you said, this won't be a proper fix for #41.

Moreover, I think implementing this would have more drawbacks than advantages. VSCode Marketplace API responses for release extensions are much larger than their latest counterparts (as @deemp mentioned here).

@yangm97
Copy link
Author

yangm97 commented Sep 4, 2023

But even if #41 was fixed, it wouldn't prevent pre-release extensions from being picked up, while it would solve the compatibility problem that would still allow unstable releases to slib by.

@AmeerTaweel
Copy link
Collaborator

I see your point now. So we should find a solution to #41 that prioritizes release extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants