Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overrides.nix #55

Open
2 of 3 tasks
deemp opened this issue Feb 18, 2024 · 1 comment
Open
2 of 3 tasks

Improve overrides.nix #55

deemp opened this issue Feb 18, 2024 · 1 comment

Comments

@deemp
Copy link
Collaborator

deemp commented Feb 18, 2024

@FraGag
Copy link

FraGag commented Apr 11, 2024

NixOS/nixpkgs#289721 was just merged into master. Once it gets merged into nixpkgs-unstable and nixos-unstable, then we'll be able to remove sourceRoot = "extension" in overrides.nix.

I advise waiting at least until it's in nixos-unstable, in case someone uses nix-vscode-extensions in a flake that changes its nixpkgs input to follow the nixos-unstable branch. If we want to be extra cautious, we could also wait for NixOS/nixpkgs#303445, which backports the change to the release-23.11 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants