Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sops downloads aarch64 binary #2

Closed
bkero opened this issue Mar 10, 2022 · 3 comments
Closed

sops downloads aarch64 binary #2

bkero opened this issue Mar 10, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@bkero
Copy link

bkero commented Mar 10, 2022

Describe the bug

The binary that this install script downloads does not indicate an architecture. That architecture is defaulting to aarch64 which is probably incorrect for most people. The script should detect the architecture and download the proper binary.

Steps to reproduce

$ uname -i
x86_64
$ asdf plugin add sops
$ asdf install sops latest
$ asdf set global sops latest
$ sops version
/home/bkero/code/asdf/lib/commands/command-exec.bash: line 28: /home/bkero/.asdf/installs/sops/3.7.2/bin/sops: cannot execute binary file: Exec format error
/home/bkero/code/asdf/lib/commands/command-exec.bash: line 28: /home/bkero/.asdf/installs/sops/3.7.2/bin/sops: Success

**Expected behavior**

The x86_64 (amd64) version of the binary should be downloaded
@bkero bkero added the bug Something isn't working label Mar 10, 2022
@nklmilojevic
Copy link
Owner

nklmilojevic commented Mar 10, 2022

hey @bkero! The current problem is that latest sops binary is not correctly compiled for amd64.

getsops/sops#1023

The PR that fixes this was merged today, but it still hasn't been released. As soon as there is a new release (I suppose 3.7.3), this will be automatically fixed.

I'm keeping this issue opened until it is resolved on the upstream.

@bkero
Copy link
Author

bkero commented Mar 10, 2022

Hi there, yes. I independently found the sops bug too. I suppose this bug could turn into a feature request at some point. I solved this by just using 3.7.1 until the bug is fixed. Thank you for the fast reply!

@nklmilojevic
Copy link
Owner

@bkero the issue is fixed in upstream now - I will make plugin better, this was just a simple c/p from my other asdf integration, skaffold :) Now everything works - let me know if something is not right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants