favicon not rendering correctly

[trym-b]

There is something wrong with the current icon, as it does not render properly, and displays the following error message when accessed directly:

To get the error above, go to this url where solrwayback is deployed: https://<domain/IP>/solrwayback/favicon.ico

[trym-b]

When testing locally, simply modify the Dockerfile.solrwayback with the following diff

diff --git a/Dockerfile.solrwayback b/Dockerfile.solrwayback
index a54bd6f..778c4d9 100644
--- a/Dockerfile.solrwayback
+++ b/Dockerfile.solrwayback
@@ -49,3 +49,5 @@ COPY --from=solrwayback-bundle \
 
 # Set URL icon for the web application
 COPY favicon.ico ${CATALINA_HOME}/webapps/solrwayback/
+COPY solrwayback.properties /root/
+COPY solrwaybackweb.properties /root/
\ No newline at end of file

The icon did appear:

[maeb]

I suspect that git-lfs has something to do with this and that the icon in the container image is not actually an icon but just an ASCII-text file.

When you build the image locally you have got the actual icon in your path and that is why it works locally.

[trym-b]

As far as I can tell we checkout the code using LFS:

https://github.com/nlnwa/solrwayback-adaption/blob/main/.github/workflows/release.yml#L27

[maeb]

Ok, found the issue: docker/build-push-action#312

Seems like we need to add a context: docker/build-push-action#312 (comment)