Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap between rolling-release branch and static commit hash #384

Closed
ryuheechul opened this issue Dec 6, 2023 · 0 comments · Fixed by #402
Closed

Gap between rolling-release branch and static commit hash #384

ryuheechul opened this issue Dec 6, 2023 · 0 comments · Fixed by #402

Comments

@ryuheechul
Copy link

Moving a conversation over to this issue for better tracking.

@ryuheechul
(commenting at specific line)
rolling release, but old commit? I'm new to niv today and I was expecting a latest commit but discovered that it's actually not after looking up the commit. (since it's nixos-unstable, expectations might be set to the latest commit instead of an fixed old commit)

this can be mitigated by manually running niv update nixpkgs but it would be nice that the latest commit is being used by default.

@nmattia
I think we used to do that, but that means checking out nixpkgs (slow) and computing its hash. Maybe there's a list of nixpkgs commits & hashes somewhere?

@ryuheechul
I see, I can see that there is a virtue of simplicity when working with static data.
In that case, maybe informing about it (the commit hash is static therefore user might want to update themselves) would be nice on top of the current existing message when niv init

$ niv init
Initializing
  Creating nix/sources.nix
  Creating nix/sources.json
  Using known 'nixpkgs' ...
  Adding package nixpkgs
    Writing new sources file
  Done: Adding package nixpkgs
Done: Initializing

# my one suggested example here
A heads up! `niv init` didn't fetch the latest commit for nixpkgs.
Run `niv update nixpkgs` if you wish to follow the latest.

@nmattia
good point. Do you want to create a ticket? It'll be easier to track

ryuheechul referenced this issue Dec 6, 2023
For security reasons niv should not initialize with a potentially
outdated nixpkgs, that won't receive updates when even when the user
calls `niv update`.
flandweber added a commit to flandweber/niv that referenced this issue May 21, 2024
flandweber added a commit to flandweber/niv that referenced this issue May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant