Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor/core/NOTICE is gone in 31.0.2 #30

Open
munix9 opened this issue May 30, 2021 · 4 comments
Open

vendor/core/NOTICE is gone in 31.0.2 #30

munix9 opened this issue May 30, 2021 · 4 comments

Comments

@munix9
Copy link
Contributor

munix9 commented May 30, 2021

vendor/core/NOTICE is gone in 31.0.2 so this leads to an error in make install

See upstream
https://android.googlesource.com/platform/system/core.git/+log/refs/tags/platform-tools-31.0.2/NOTICE
https://android.googlesource.com/platform/system/core.git/+/2f51435809f29d2fa3e3dab82617813c121e9721

See github actions build
https://github.com/munix9/android-tools/runs/2703531103?check_suite_focus=true#step:7:2184

Install the project...
/usr/bin/cmake -P cmake_install.cmake
-- Install configuration: "Release"
-- Installing: /usr/local/share/bash-completion/completions/adb
-- Installing: /usr/local/share/bash-completion/completions/fastboot
-- Installing: /usr/local/share/zsh/site-functions/_adb
-- Installing: /usr/local/share/zsh/site-functions/_fastboot
-- Installing: /usr/local/bin/adb
-- Installing: /usr/local/bin/fastboot
-- Installing: /usr/local/bin/mke2fs.android
-- Installing: /usr/local/bin/simg2img
-- Installing: /usr/local/bin/img2simg
-- Installing: /usr/local/bin/append2simg
-- Installing: /usr/local/share/android-tools/completions/adb
-- Installing: /usr/local/share/android-tools/completions/fastboot
CMake Error at vendor/cmake_install.cmake:174 (file):
  file INSTALL cannot find
  "/__w/android-tools/android-tools/vendor/core/NOTICE": No such file or
  directory.
Call Stack (most recent call first):
  cmake_install.cmake:48 (include)

make: *** [Makefile:118: install] Error 1
Error: Process completed with exit code 2.```
@nmeum
Copy link
Owner

nmeum commented May 30, 2021

Thanks for pointing this out, keep in mind though that 31.0.2 is not merged yet.

@munix9
Copy link
Contributor Author

munix9 commented May 30, 2021

Yes, I know, this is currently only for testing.
Another question: Where do the used patches actually come from?

@nmeum
Copy link
Owner

nmeum commented May 30, 2021

Another question: Where do the used patches actually come from?

From contributors to this repository, initially a few have been copied from Arch.

@nmeum
Copy link
Owner

nmeum commented Jun 6, 2021

I think I will just remove the NOTICE for the upcoming release, see #20 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants