Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in persian formatter digits do not convert to persian digits #145

Open
haniehtarbiat opened this issue Oct 26, 2020 · 3 comments
Open

in persian formatter digits do not convert to persian digits #145

haniehtarbiat opened this issue Oct 26, 2020 · 3 comments
Labels
goodFirstTask Ideal candidates for easy Pull Requests. help wanted

Comments

@haniehtarbiat
Copy link

when build formatter by language-strings/fa the text convert to persian language but the digits don't convert to persian digits.

@nmn
Copy link
Owner

nmn commented Nov 23, 2020

I rely on pull request for translations. The language strings can take function that can convert digits to the right format. You're welcome to make a pull request. I will be happy to help. We basically just need a function to convert to Persian digits.

@nmn nmn added help wanted goodFirstTask Ideal candidates for easy Pull Requests. labels Nov 23, 2020
@nmn
Copy link
Owner

nmn commented Jun 10, 2022

While this was not possible in the past, it might be possible to use the Intl module to convert the numbers to various locales now.

@nmn
Copy link
Owner

nmn commented Jun 10, 2022

I've done this by using the Intl module when available in the latest release.

Looking for help verifying the results. (I'm not a native persian or arabic speaker or reader. As such I don't know if I've completely messed up the numbers in the RTL language)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goodFirstTask Ideal candidates for easy Pull Requests. help wanted
Projects
None yet
Development

No branches or pull requests

2 participants