Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nobl9/nobl9-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.84.0-rc3
Choose a base ref
...
head repository: nobl9/nobl9-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.84.0-rc4
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Aug 6, 2024

  1. chore: Update module golang.org/x/tools/cmd/goimports to v0.24.0 (#512) 

    [![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| golang.org/x/tools/cmd/goimports | `v0.23.0` -> `v0.24.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/golang.org%2fx%2ftools%2fcmd%2fgoimports/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/golang.org%2fx%2ftools%2fcmd%2fgoimports/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/golang.org%2fx%2ftools%2fcmd%2fgoimports/v0.23.0/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/golang.org%2fx%2ftools%2fcmd%2fgoimports/v0.23.0/v0.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" (UTC), Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/nobl9/nobl9-go).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xOC4xNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    @renovate
    renovate[bot] authored Aug 6, 2024
    Loading
    Loading status checks…

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    97658dc View commit details

Commits on Aug 7, 2024

  1. fix: Removing redundant validation in LogicMonitor [PC-13783] (#514) 

    ## Release Notes

Removing redundant validation for `ClientID` and `ClientSecret` in Logic Monitor
    @dawidwisn
    dawidwisn authored Aug 7, 2024
    Loading
    Loading status checks…
    Copy the full SHA
    70e68d0 View commit details
Showing with 1 addition and 27 deletions.
  1. +1 −1 Makefile
  2. +0 −8 manifest/v1alpha/direct/validation.go
  3. +0 −18 manifest/v1alpha/direct/validation_test.go
2 changes: 1 addition & 1 deletion Makefile
View file
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ GOLANGCI_LINT_VERSION := v1.59.1
# renovate datasource=go depName=golang.org/x/vuln/cmd/govulncheck
GOVULNCHECK_VERSION := v1.1.3
# renovate datasource=go depName=golang.org/x/tools/cmd/goimports
GOIMPORTS_VERSION := v0.23.0
GOIMPORTS_VERSION := v0.24.0
# renovate datasource=go depName=github.com/vburenin/ifacemaker
IFACEMAKER_VERSION := v1.2.1

8 changes: 0 additions & 8 deletions manifest/v1alpha/direct/validation.go
View file
Original file line number Diff line number Diff line change
@@ -208,14 +208,6 @@ var (
WithName("account").
Required().
Rules(validation.StringNotEmpty()),
validation.For(func(l LogicMonitorConfig) string { return l.AccessID }).
WithName("accessId").
Required().
Rules(validation.StringNotEmpty()),
validation.For(func(l LogicMonitorConfig) string { return l.AccessKey }).
WithName("accessKey").
Required().
Rules(validation.StringNotEmpty()),
)
azurePrometheusValidation = validation.New[AzurePrometheusConfig](
urlPropertyRules(func(s AzurePrometheusConfig) string { return s.URL }),
18 changes: 0 additions & 18 deletions manifest/v1alpha/direct/validation_test.go
View file
Original file line number Diff line number Diff line change
@@ -923,24 +923,6 @@ func TestValidateSpec_LogicMonitor(t *testing.T) {
Code: validation.ErrorCodeRequired,
})
})
t.Run("invalid accountID", func(t *testing.T) {
direct := validDirect(v1alpha.LogicMonitor)
direct.Spec.LogicMonitor.AccessID = ""
err := validate(direct)
testutils.AssertContainsErrors(t, direct, err, 1, testutils.ExpectedError{
Prop: "spec.logicMonitor.accessId",
Code: validation.ErrorCodeRequired,
})
})
t.Run("invalid accessKey", func(t *testing.T) {
direct := validDirect(v1alpha.LogicMonitor)
direct.Spec.LogicMonitor.AccessKey = ""
err := validate(direct)
testutils.AssertContainsErrors(t, direct, err, 1, testutils.ExpectedError{
Prop: "spec.logicMonitor.accessKey",
Code: validation.ErrorCodeRequired,
})
})
}

func TestValidateSpec_AzurePrometheus(t *testing.T) {