Makefile

@@ -8,7 +8,7 @@ GO_ENUM_VERSION := v0.6.0
 # renovate datasource=github-releases depName=securego/gosec
 GOSEC_VERSION := v2.20.0
 # renovate datasource=github-releases depName=golangci/golangci-lint
-GOLANGCI_LINT_VERSION := v1.59.1
+GOLANGCI_LINT_VERSION := v1.60.1
 # renovate datasource=go depName=golang.org/x/vuln/cmd/govulncheck
 GOVULNCHECK_VERSION := v1.1.3
 # renovate datasource=go depName=golang.org/x/tools/cmd/goimports
@@ -44,6 +44,9 @@ test:
 ## Run all end-to-end tests (requires Nobl9 platform credentials).
 test/e2e:
 	# The '-count=1' flag disables tests results caching, as per https://go.dev/doc/go1.10#test.
+	@if [ "$(GITHUB_ACTIONS)" != "true" ]; then \
+		export NOBL9_SDK_TEST_RUN_SEQUENTIAL_APPLY_AND_DELETE=true; \
+	fi; \
 	go test -count=1 -race -test.v -timeout=5m -tags=e2e_test ./tests
 
 ## Record tests and save them in ./bin/recorded-tests.json.

docs/DEVELOPMENT.md

@@ -29,8 +29,7 @@ and makes local debugging easier.
 
 ## Testing
 
-Currently nobl9-go is automatically verified with unit tests only.
-It is encouraged to create a simple MVP program which verifies the introduced
+It is encouraged to create a simple MVP program which verifies that introduced
 changes work. There's a dedicated section in PR template `## Testing` which
 is a great place to add such `main.go` code snippet.
 Here's an example:
@@ -87,6 +86,20 @@ rules:
 If you wish to record the tests run `make test/record`.
 By default, the tests are recorded inside `./bin` folder.
 
+### End-to-end test
+
+Tests which are run against Nobl9 API are located under [tests](../tests/)
+folder.
+They are standard Go tests, annotated with build tag `e2e_test`, they can
+be executed with `make test/e2e`.
+In order to run them, a set of basic Nobl9 credentials is required:
+
+- *NOBL9_SDK_CLIENT_ID*
+- *NOBL9_SDK_CLIENT_SECRET*
+
+There's also a [dispatch action](https://github.com/nobl9/nobl9-go/actions/workflows/e2e-tests-dispatch.yml)
+available.
+
 ## Releases
 
 Refer to [RELEASE.md](./RELEASE.md) for more information on release process.

docs/RELEASE.md

@@ -16,7 +16,7 @@ created. For example, If you end up changing PR title from `sec:` to `fix:`
 you'll have to manually remove `security` label.
 
 On each commit to `main` branch, Release Drafter will update the next release
-draft. Once you're ready to create new version, simply publish this draft.
+draft.
 
 In addition to Release Drafter, we're also running a script which extracts
 explicitly listed release notes and breaking changes which are optionally

internal/manifest/objects_test.go

@@ -2,6 +2,7 @@ package manifest
 
 import (
 	"context"
+	"os"
 	"path/filepath"
 	"testing"
 
@@ -17,7 +18,7 @@ import (
 
 func TestMain(m *testing.M) {
 	v1alphaParser.UseStrictDecodingMode = true
-	m.Run()
+	os.Exit(m.Run())
 }
 
 func TestObjectExamples(t *testing.T) {

internal/manifest/v1alpha/examples/slo.go

@@ -1,6 +1,8 @@
 package v1alphaExamples
 
 import (
+	"fmt"
+
 	"github.com/nobl9/nobl9-go/manifest/v1alpha"
 	v1alphaSLO "github.com/nobl9/nobl9-go/manifest/v1alpha/slo"
 	"github.com/nobl9/nobl9-go/manifest/v1alpha/twindow"
@@ -129,8 +131,14 @@ var badOverTotalVariants = []string{
 	metricVariantBadRatio,
 }
 
+type sloExampleInterface interface {
+	Example
+	fmt.Stringer
+	SLO() v1alphaSLO.SLO
+}
+
 func SLO() []Example {
-	baseExamples := make([]sloExample, 0)
+	baseExamples := make([]sloExampleInterface, 0)
 	for _, dataSourceType := range standardGoodOverTotalMetrics {
 		baseExamples = append(baseExamples, createVariants(dataSourceType, goodOverTotalVariants, nil)...)
 	}
@@ -146,8 +154,9 @@ func SLO() []Example {
 			)...)
 		}
 	}
-	variants := make([]sloExample, 0, len(baseExamples)*4)
-	for _, example := range baseExamples {
+	baseExamples = append(baseExamples, sloCompositeExample{})
+	variants := make([]sloExampleInterface, 0, len(baseExamples)*4)
+	for _, baseExample := range baseExamples {
 		for _, timeWindow := range []twindow.TimeWindowTypeEnum{
 			twindow.Rolling,
 			twindow.Calendar,
@@ -156,15 +165,25 @@ func SLO() []Example {
 				v1alphaSLO.BudgetingMethodTimeslices,
 				v1alphaSLO.BudgetingMethodOccurrences,
 			} {
-				example = sloExample{
-					DataSourceType:   example.DataSourceType,
-					BudgetingMethod:  method,
-					TimeWindowType:   timeWindow,
-					MetricVariant:    example.MetricVariant,
-					MetricSubVariant: example.MetricSubVariant,
+				switch example := baseExample.(type) {
+				case sloExample:
+					variants = append(variants, sloExample{
+						sloBaseExample: sloBaseExample{
+							BudgetingMethod: method,
+							TimeWindowType:  timeWindow,
+						},
+						DataSourceType:   example.DataSourceType,
+						MetricVariant:    example.MetricVariant,
+						MetricSubVariant: example.MetricSubVariant,
+					})
+				case sloCompositeExample:
+					variants = append(variants, sloCompositeExample{
+						sloBaseExample: sloBaseExample{
+							BudgetingMethod: method,
+							TimeWindowType:  timeWindow,
+						},
+					})
 				}
-				example.SLO = example.Generate()
-				variants = append(variants, example)
 			}
 		}
 	}
@@ -175,8 +194,8 @@ func createVariants(
 	dataSourceType v1alpha.DataSourceType,
 	metricVariants []metricVariant,
 	metricSubVariants []metricSubVariant,
-) []sloExample {
-	examples := make([]sloExample, 0, len(metricVariants)*(1+len(metricSubVariants)))
+) []sloExampleInterface {
+	examples := make([]sloExampleInterface, 0, len(metricVariants)*(1+len(metricSubVariants)))
 	for _, example := range metricVariants {
 		if len(metricSubVariants) == 0 {
 			examples = append(examples, sloExample{

internal/manifest/v1alpha/examples/slo_composite.go

@@ -0,0 +1,115 @@
+package v1alphaExamples
+
+import (
+	"fmt"
+	"time"
+
+	"github.com/nobl9/nobl9-go/manifest/v1alpha"
+
+	v1alphaSLO "github.com/nobl9/nobl9-go/manifest/v1alpha/slo"
+	"github.com/nobl9/nobl9-go/sdk"
+)
+
+type sloCompositeExample struct {
+	sloBaseExample
+}
+
+func (s sloCompositeExample) GetObject() any {
+	return s.SLO()
+}
+
+func (s sloCompositeExample) GetVariant() string {
+	return "composite-slo"
+}
+
+func (s sloCompositeExample) GetSubVariant() string {
+	return s.String()
+}
+
+func (s sloCompositeExample) GetYAMLComments() []string {
+	return []string{
+		fmt.Sprintf("Composite SLO"),
+		fmt.Sprintf("Budgeting method: %s", s.BudgetingMethod),
+		fmt.Sprintf("Time window type: %s", s.TimeWindowType),
+	}
+}
+
+func (s sloCompositeExample) String() string {
+	return fmt.Sprintf(
+		"Composite SLO using %s budgeting method and %s time window",
+		s.BudgetingMethod,
+		s.TimeWindowType,
+	)
+}
+
+func (s sloCompositeExample) SLO() v1alphaSLO.SLO {
+	return v1alphaSLO.New(
+		v1alphaSLO.Metadata{
+			Name:        "user-experience-slo",
+			DisplayName: "User experience SLO",
+			Project:     sdk.DefaultProject,
+			Labels: v1alpha.Labels{
+				"team":   {"green", "ux"},
+				"env":    {"prod", "dev"},
+				"region": {"us", "eu"},
+				"area":   {"user-experience"},
+			},
+			Annotations: v1alpha.MetadataAnnotations{
+				"team":   "ux",
+				"env":    "prod",
+				"region": "us",
+				"area":   "user-experience",
+			},
+		},
+		v1alphaSLO.Spec{
+			Description:     "Example composite SLO",
+			Service:         "web-app",
+			Indicator:       nil,
+			BudgetingMethod: s.BudgetingMethod.String(),
+			Attachments:     exampleAttachments(),
+			AlertPolicies:   exampleAlertPolicies(),
+			AnomalyConfig:   nil,
+			TimeWindows:     exampleTimeWindows(s.TimeWindowType),
+			Objectives: []v1alphaSLO.Objective{
+				{
+					ObjectiveBase: v1alphaSLO.ObjectiveBase{
+						DisplayName: "User experience",
+						Value:       ptr(0.0),
+						Name:        "user-experience",
+					},
+					BudgetTarget:    ptr(0.95),
+					Primary:         ptr(true),
+					TimeSliceTarget: exampleTimeSliceTarget(s.BudgetingMethod),
+					Composite: &v1alphaSLO.CompositeSpec{
+						MaxDelay: (45 * time.Minute).String(),
+						Components: v1alphaSLO.Components{
+							Objectives: []v1alphaSLO.CompositeObjective{
+								{
+									Project:     "e-commerce",
+									SLO:         "store-web-latency",
+									Objective:   "latency",
+									Weight:      1,
+									WhenDelayed: v1alphaSLO.WhenDelayedCountAsGood,
+								},
+								{
+									Project:     "e-commerce",
+									SLO:         "store-web-availability",
+									Objective:   "availability",
+									Weight:      4,
+									WhenDelayed: v1alphaSLO.WhenDelayedCountAsBad,
+								},
+								{
+									Project:     "external-services",
+									SLO:         "payment-integration-availability",
+									Objective:   "availability",
+									Weight:      3,
+									WhenDelayed: v1alphaSLO.WhenDelayedIgnore,
+								},
+							},
+						},
+					},
+				},
+			},
+		},
+	)
+}