fix: reorder objective validation rules to produce more adequate composite objective validation messages [PC-12021] #339
+180
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikodemrafalski
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
marcinlawnik
approved these changes
Mar 25, 2024
nikodemrafalski
force-pushed
the
PC-12021-composite-objectives-validation
branch
from
8b840e4 to
2787f54
Compare
BSski
approved these changes
Mar 28, 2024
nieomylnieja
approved these changes
Mar 28, 2024
nikodemrafalski
force-pushed
the
PC-12021-composite-objectives-validation
branch
from
13f6616 to
40ea8bf
Compare
…osite objective validation messages
nikodemrafalski
force-pushed
the
PC-12021-composite-objectives-validation
branch
from
e8684cb to
3e9d49f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validating if there's more than one composite objective in SLO should take precedence over objective uniqueness validation