Skip to content

feat: PC-12282 Introduce metadata annotations #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2024

Conversation

skrolikiewicz
Copy link
Member

@skrolikiewicz skrolikiewicz commented Mar 26, 2024

Release Notes

Added the ability to define annotations on SLOs, Services, Projects, and Alert Policies.
Similarly to Kubernetes, users can now use either labels or annotations to attach metadata to objects.

The changes are compatible with the Nobl9 1.75, which will be released on 11.04.2024.

Summary

This PR introduces a mechanism for users to define annotations on SLOs, Services, Projects, and Alert Policies (the same objects to which we can assign labels).
Similarly to Kubernetes, users can use either labels or annotations to attach metadata to objects.

Annotations, similarly to k8s annotations, are defined as key/value maps:

"metadata": {
  "annotations": {
    "key1" : "value1",
    "key2" : "value2"
  }
}

@n9-machine-user n9-machine-user added enhancement New feature or request go minor labels Mar 26, 2024
@skrolikiewicz skrolikiewicz force-pushed the PC-12282-back-end-only-object-attributes branch 4 times, most recently from 018e27e to a581c33 Compare April 4, 2024 09:42
@skrolikiewicz skrolikiewicz marked this pull request as ready for review April 4, 2024 12:33
@skrolikiewicz skrolikiewicz force-pushed the PC-12282-back-end-only-object-attributes branch 2 times, most recently from f80cb16 to b272859 Compare April 5, 2024 12:21

Verified

This commit was signed with the committer’s verified signature.
NeQuissimus Tim Steinbach

Verified

This commit was signed with the committer’s verified signature.
fpletz Franz Pletz

Verified

This commit was signed with the committer’s verified signature.
fpletz Franz Pletz
@skrolikiewicz skrolikiewicz force-pushed the PC-12282-back-end-only-object-attributes branch from b272859 to 34a63be Compare April 9, 2024 10:15
Copy link
Collaborator

@nieomylnieja nieomylnieja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done :)

@skrolikiewicz skrolikiewicz force-pushed the PC-12282-back-end-only-object-attributes branch from 777fbff to 90610ac Compare April 9, 2024 10:29
@skrolikiewicz skrolikiewicz merged commit a55aa67 into main Apr 9, 2024
5 checks passed
@skrolikiewicz skrolikiewicz deleted the PC-12282-back-end-only-object-attributes branch April 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants