feat: Add rules for maps in validation #345
Merged
+643
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
force-pushed
the
feat-add-rules-for-map-validation
branch
from
a251711 to
369cb85
Compare
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
…nobl9-go into feat-add-rules-for-map-validation
skrolikiewicz
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we're lacking any constructs in
validationpkg to verify maps. While it can be done more "manually" it would be nice to have a similar validator to currentForEach, which should probably be renamed toForSlice.