feat: PC-12071: Add support for alerting window to more measurements #361
+54
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobl9-adam-szymanski
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
piotrkwarcinski
approved these changes
Apr 11, 2024
nobl9-adam-szymanski
deleted the
PC-12071-alerting-window-for-time-to-burn-budget
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add support to
timeToBurnBudgetandtimeToBurnEntireBudgetalerting conditions. Today, users can only define alerting window foraverageBurnRatecondition type.Summary
Allow to define lasts for or alerting window for two more conditions. Added support with exactly the same validation rules as for average burn rate. Keep validation rules the same as for average burn rate.
I deleted
averageBudgetWithAlertingWindowValueValidationvalidation since there is no correlation between value type (float64 or date time) and alerting window.