fix: PC-12544 Add validation for components list to be required (even if empty) #403
+24
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
New SLO has elements at depth of 4:
A list of objectives can be empty.
It may be possible that a typo is made at the highest depth (
objectives
), which results in no error, but the list being empty (while the user expects the objectives to be there).Summary
Made the
components
list required, so that an empty array(YAML) / slice(Go) needs to be passed instead of omitted YAML property or nil slice.Related changes
None
Testing
Added unit tests, sample YAML with the issue:
Correct YAML: