Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PC-12488 PC-12490 Add LogicMonitor Direct, Agent and Metric Spec #408

Merged
merged 5 commits into from
May 13, 2024

Conversation

dawidwisn
Copy link
Contributor

Motivation

Support new integration with Logic Monitor.

Summary

Add Logic Monitor Direct, Agent, and Metric Spec

Release Notes

New fields in Agent spec:

 spec:
    logicMonitor: 
      account: ""
  • logicMonitor - name of the new integration
  • account - account name from LM (as in .logicmonitor.com)

New fields in Direct spec:

 spec:
    logicMonitor: 
       accessId: ""
       accessKey: "" 
       account: ""
  • logicMonitor - name of the new integration
  • accessID and accessKey - values from Logic Monitor (link)
  • account - account name from LM (as in .logicmonitor.com)

New fields in Metric Spec, example:

 countMetrics:
        incremental: false
        good:
          logicMonitor:
            queryType: "device_metrics"
            deviceDataSourceInstanceId: 11
            graphId: 123
            line: MAX
        total:
          logicMonitor:
            queryType: "device_metrics"
            deviceDataSourceInstanceId: 122
            graphId: 123
            line: TOTAL
  • logicMonitor - name of the new integration
  • queryType - there is support only for one type of query deviceMetrics
  • deviceDataSourceInstanceId - number of the device data source instance Id from Ligic Monitor (list)
  • graphId - graph ID
  • line - line.label from the response from REST endpoint 'get device instance data' (link)

dawidwisn and others added 4 commits May 9, 2024 11:18
@n9-machine-user n9-machine-user added enhancement New feature or request go minor labels May 13, 2024
@dawidwisn dawidwisn marked this pull request as ready for review May 13, 2024 09:21
@dawidwisn dawidwisn merged commit 10c27e2 into main May 13, 2024
5 checks passed
@dawidwisn dawidwisn deleted the PC-12488_PC-12490-support-logic-monitor branch May 13, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants