-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Define manifest objects examples in code #477
Merged
Merged
+28,705
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Loading status checks…
/build |
daniel-zelazny
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work 🚀
renovate bot
referenced
this pull request
in nobl9/sloctl
Jul 12, 2024
Loading
Loading status checks…
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/nobl9/nobl9-go](https://togithub.com/nobl9/nobl9-go) | `v0.83.0-rc3` -> `v0.83.0-rc4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary> ### [`v0.83.0-rc4`](https://togithub.com/nobl9/nobl9-go/releases/tag/v0.83.0-rc4) [Compare Source](https://togithub.com/nobl9/nobl9-go/compare/v0.83.0-rc3...v0.83.0-rc4) #### What's Changed - feat: Define manifest objects examples in code by [@​nieomylnieja](https://togithub.com/nieomylnieja) in [https://github.com/nobl9/nobl9-go/pull/477](https://togithub.com/nobl9/nobl9-go/pull/477) - chore: Add Alert Method e2e tests by [@​nieomylnieja](https://togithub.com/nieomylnieja) in [https://github.com/nobl9/nobl9-go/pull/481](https://togithub.com/nobl9/nobl9-go/pull/481) - chore: Update module github.com/aws/aws-sdk-go to v1.54.16 by [@​renovate](https://togithub.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/487](https://togithub.com/nobl9/nobl9-go/pull/487) - chore: Add v1alpha RoleBinding e2e tests by [@​nieomylnieja](https://togithub.com/nieomylnieja) in [https://github.com/nobl9/nobl9-go/pull/486](https://togithub.com/nobl9/nobl9-go/pull/486) - chore: Add Alert Method e2e tests by [@​nieomylnieja](https://togithub.com/nieomylnieja) in [https://github.com/nobl9/nobl9-go/pull/488](https://togithub.com/nobl9/nobl9-go/pull/488) - chore: Update module github.com/aws/aws-sdk-go to v1.54.17 by [@​renovate](https://togithub.com/renovate) in [https://github.com/nobl9/nobl9-go/pull/489](https://togithub.com/nobl9/nobl9-go/pull/489) - feat: PC-13045 Good total single query experimental support by [@​marcinlawnik](https://togithub.com/marcinlawnik) in [https://github.com/nobl9/nobl9-go/pull/458](https://togithub.com/nobl9/nobl9-go/pull/458) **Full Changelog**: nobl9/nobl9-go@v0.83.0-rc3...v0.83.0-rc4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJnb2xhbmciLCJyZW5vdmF0ZSJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're currently lacking in examples for our
v1alpha
objects.This PR covers that hole by adding utilities for generating these examples and verifying them.
Release Notes
Added extended examples to the
v1alpha
objects with different configuration variants.