Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add SLO end-to-end tests #494

Merged
merged 4 commits into from
Jul 18, 2024
Merged

chore: Add SLO end-to-end tests #494

merged 4 commits into from
Jul 18, 2024

Conversation

nieomylnieja
Copy link
Collaborator

@nieomylnieja nieomylnieja commented Jul 17, 2024

Added SLO end-to-end tests.

The bigger object batches are run in batches, unfortunately for some of the objects it is not possible to run multiple apply operations concurrently, so we need to do it synchronously.

The tested SLOs operate on static Agent and Direct sets which are applied before each test but do are not removed after the tests finish, they also have static names and project, so the apply will not create any new objects if they were already applied.

Extra changes

  • switched SLO examples to use Agent instead of Direct as this is safer, since not all integrations support Direct mode
  • minor issues with Agent and Direct examples
  • fixed docgen which was not working with the current examples
  • fixed bad over total metric examples which were generated incorrectly
  • added new line in http.go for retry log which was there once before but got removed by accident

Copy link
Contributor

@daniel-zelazny daniel-zelazny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎖️

@nieomylnieja nieomylnieja merged commit 4a6a10e into main Jul 18, 2024
5 checks passed
@nieomylnieja nieomylnieja deleted the add-slo-e2e-tests branch July 18, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants