Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PC-13263 Add Report kind #495

Merged
merged 30 commits into from
Aug 6, 2024
Merged

feat: PC-13263 Add Report kind #495

merged 30 commits into from
Aug 6, 2024

Conversation

natalialanga
Copy link
Contributor

@natalialanga natalialanga commented Jul 22, 2024

Summary

Add Report kind for creating, updating and deleting reports. Only System Health Review report type is supported.

Release Notes

New Report kind for handling creating, updating and deleting reports. Only System Health Review report type is currently supported. This feature is currently in early access, and is available only on demand. If you want to utilize SDK for reports management, please reach out to Nobl9 Support.

@natalialanga natalialanga changed the title PC-13263 Add Report kind feat: PC-13263 Add Report kind Jul 22, 2024
@n9-machine-user n9-machine-user added enhancement New feature or request minor labels Jul 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@natalialanga natalialanga marked this pull request as ready for review July 31, 2024 08:53
Copy link
Contributor

@lukasz-dobek lukasz-dobek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments left (the main thing to discuss are label validation rules or lack thereof), overall looks really good!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@lukasz-dobek lukasz-dobek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment left!

@lukasz-dobek lukasz-dobek enabled auto-merge (squash) August 6, 2024 10:01
@lukasz-dobek lukasz-dobek requested review from skrolikiewicz and removed request for skrolikiewicz August 6, 2024 10:02
@lukasz-dobek lukasz-dobek dismissed stale reviews from skrolikiewicz and nieomylnieja August 6, 2024 10:19

Stale review, requested changes were applied.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lukasz-dobek lukasz-dobek merged commit c739a50 into main Aug 6, 2024
5 checks passed
@lukasz-dobek lukasz-dobek deleted the PC-13263-reports-by-yaml branch August 6, 2024 10:22
lukasz-dobek pushed a commit to nobl9/sloctl that referenced this pull request Aug 13, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
## Summary

Add posibility to apply/delete/get reports.

## Related changes

nobl9/nobl9-go#495

## Release Notes

New `Report` kind for handling creating, updating and deleting reports.
This feature is currently in early access, and is available only on
demand. If you want to utilize sloctl for reports management, please reach
out to Nobl9 Support.

---------

Co-authored-by: lukasz-dobek <lukasz.dobek@nobl9.com>
natalialanga added a commit to nobl9/terraform-provider-nobl9 that referenced this pull request Sep 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
## Summary

Add support for managing System Health Review Report via terraform.

## Related Changes

nobl9/nobl9-go#495
nobl9/nobl9-go#530

## Testing

TBD

## Release Notes

Handle creating, updating and deleting reports. Only System Health
Review report type is currently supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants