chore: Allow sequential apply/delete execution for end-to-end tests #498
+54
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
BSski
approved these changes
Jul 25, 2024
nieomylnieja
deleted the
allow-sequential-apply-and-delete-operations-for-e2e-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since we're currently running into concurrency problems, we need to be able to constrain parallelism of apply/delete operations on demand.
Testing
export NOBL9_SDK_TEST_RUN_SEQUENTIAL_APPLY_AND_DELETE=true make test/e2ehttps://github.com/nobl9/nobl9-go/actions/runs/10095740091