Weekly Digest (16 December, 2018 - 23 December, 2018)

[weekly-digest]

Here's the Weekly Digest for nock/nock:

---

ISSUES

Last week 48 issues were created.
Of these, 44 issues have been closed and 4 issues are still open.

OPEN ISSUES

💚 #1327 The automated release is failing 🚨, by nockbot
💚 #1308 fix: package.engines shows incorrect versions and is supposed to be an object, by paulmelnikow
💚 #1307 fix: package.engines is supposed to be an object, by paulmelnikow
💚 #1285 Replace lodash with native where appropriate, by paulmelnikow

CLOSED ISSUES

❤️ #1330 nockBack before preprocessing function not executing if there are no fixtures, by protoEvangelion
❤️ #1329 docs(README): Get Coveralls badge up to date, by paulmelnikow
❤️ #1328 Remove FakeTransformStream shim for old node versions, by paulmelnikow
❤️ #1326 style: Turn on some (mostly) autofixable rules, by paulmelnikow
❤️ #1325 run prettier on update, by gr2m
❤️ #1324 Set up eslint-config-standard, by paulmelnikow
❤️ #1323 The automated release is failing 🚨, by nockbot
❤️ #1322 test(test_back): Fix test broken in merge conflict, by paulmelnikow
❤️ #1321 The automated release is failing 🚨, by nockbot
❤️ #1320 update semantic-release to beta.13, by gr2m
❤️ #1319 The automated release is failing 🚨, by nockbot
❤️ #1318 Remove conditional for now-unsupported Node versions, by paulmelnikow
❤️ #1317 test(test_common): Pick up some coverage, by paulmelnikow
❤️ #1316 test(test_back): Cover both of the ‘no fs’ code paths, by paulmelnikow
❤️ #1315 test(test_data): Remove a wide-bracket regression test, by paulmelnikow
❤️ #1314 test(test_content_encoding): Rewrite using got, async/await, by paulmelnikow
❤️ #1313 test(test_complex_querystring): Rewrite using got, qs, async/await, by paulmelnikow
❤️ #1312 test(test_back): Import test from tap for consistency, by paulmelnikow
❤️ #1311 Run prettier, by paulmelnikow
❤️ #1310 Set up Prettier, by paulmelnikow
❤️ #1309 Update badges, by paulmelnikow
❤️ #1306 test(test_common): Rewrite in more direct style, by paulmelnikow
❤️ #1305 Test runner, by paulmelnikow
❤️ #1304 The automated release is failing 🚨, by nockbot
❤️ #1303 run release stage on [Version].x, next, beta branches, by gr2m
❤️ #1302 Coverage updates, by paulmelnikow
❤️ #1301 fix: Fix some errors detected by LGTM, by paulmelnikow
❤️ #1300 Code formatting, by paulmelnikow
❤️ #1299 Drop support for Node 6, by paulmelnikow
❤️ #1298 test(back): Fill in code coverage, by paulmelnikow
❤️ #1297 build on branches for semantic-release preview/next/maintenance releases, by gr2m
❤️ #1296 fix(socket): Remove dead code, by paulmelnikow
❤️ #1295 fix(mixin): Remove dead code, by paulmelnikow
❤️ #1294 test(test_basic_auth): Rewrite using got + async/await, by paulmelnikow
❤️ #1293 bump semantic-release to v16 beta, by gr2m
❤️ #1292 test(test_back): Improve style and readability, by paulmelnikow
❤️ #1291 remove obsolete coveralls configuration, by gr2m
❤️ #1290 test(test_s3): Add fixme comment, by paulmelnikow
❤️ #1289 chore: Only run coverage in latest Node, by paulmelnikow
❤️ #1288 test(test_aws_dynamo): Remove AWS Dynamo functional test, by paulmelnikow
❤️ #1287 test(test_abort): Improve style + readability, by paulmelnikow
❤️ #1286 test: Replace lodash with native in tests, by paulmelnikow
❤️ #1284 chore: Ignore ‘tests/ssl/index.js’ for coverage, by paulmelnikow
❤️ #1283 test(test_recorder): De-airplane remaining recorder tests, by paulmelnikow

LIKED ISSUE

👍 #1303 run release stage on [Version].x, next, beta branches, by gr2m
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #1302 Coverage updates, by paulmelnikow
It received 11 comments.

---

PULL REQUESTS

Last week, 39 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 3 pull requests were updated.
💛 #1308 fix: package.engines shows incorrect versions and is supposed to be an object, by paulmelnikow
💛 #1307 fix: package.engines is supposed to be an object, by paulmelnikow
💛 #1209 Nock-1077 Remove airplane mode, by jlilja

MERGED PULL REQUEST

Last week, 36 pull requests were merged.
💜 #1329 docs(README): Get Coveralls badge up to date, by paulmelnikow
💜 #1328 Remove FakeTransformStream shim for old node versions, by paulmelnikow
💜 #1326 style: Turn on some (mostly) autofixable rules, by paulmelnikow
💜 #1325 run prettier on update, by gr2m
💜 #1324 Set up eslint-config-standard, by paulmelnikow
💜 #1322 test(test_back): Fix test broken in merge conflict, by paulmelnikow
💜 #1320 update semantic-release to beta.13, by gr2m
💜 #1318 Remove conditional for now-unsupported Node versions, by paulmelnikow
💜 #1317 test(test_common): Pick up some coverage, by paulmelnikow
💜 #1316 test(test_back): Cover both of the ‘no fs’ code paths, by paulmelnikow
💜 #1315 test(test_data): Remove a wide-bracket regression test, by paulmelnikow
💜 #1314 test(test_content_encoding): Rewrite using got, async/await, by paulmelnikow
💜 #1313 test(test_complex_querystring): Rewrite using got, qs, async/await, by paulmelnikow
💜 #1312 test(test_back): Import test from tap for consistency, by paulmelnikow
💜 #1311 Run prettier, by paulmelnikow
💜 #1310 Set up Prettier, by paulmelnikow
💜 #1309 Update badges, by paulmelnikow
💜 #1306 test(test_common): Rewrite in more direct style, by paulmelnikow
💜 #1303 run release stage on [Version].x, next, beta branches, by gr2m
💜 #1301 fix: Fix some errors detected by LGTM, by paulmelnikow
💜 #1299 Drop support for Node 6, by paulmelnikow
💜 #1298 test(back): Fill in code coverage, by paulmelnikow
💜 #1297 build on branches for semantic-release preview/next/maintenance releases, by gr2m
💜 #1296 fix(socket): Remove dead code, by paulmelnikow
💜 #1295 fix(mixin): Remove dead code, by paulmelnikow
💜 #1294 test(test_basic_auth): Rewrite using got + async/await, by paulmelnikow
💜 #1293 bump semantic-release to v16 beta, by gr2m
💜 #1292 test(test_back): Improve style and readability, by paulmelnikow
💜 #1291 remove obsolete coveralls configuration, by gr2m
💜 #1290 test(test_s3): Add fixme comment, by paulmelnikow
💜 #1288 test(test_aws_dynamo): Remove AWS Dynamo functional test, by paulmelnikow
💜 #1287 test(test_abort): Improve style + readability, by paulmelnikow
💜 #1286 test: Replace lodash with native in tests, by paulmelnikow
💜 #1284 chore: Ignore ‘tests/ssl/index.js’ for coverage, by paulmelnikow
💜 #1283 test(test_recorder): De-airplane remaining recorder tests, by paulmelnikow
💜 #1281 test(test_recorder): De-airplane more recorder tests, by paulmelnikow

---

COMMITS

Last week there were 42 commits.
🛠️ docs(README): Get Coveralls badge up to date by paulmelnikow
🛠️ refactor: remove FakeTransformStream shim for old node versions (#1328) by paulmelnikow
🛠️ docs(README): badges (#1309) by paulmelnikow
🛠️ style: Manual fixes by paulmelnikow
🛠️ style: Autofixes by paulmelnikow
🛠️ style: Turn on some (mostly) autofixable rules by paulmelnikow
🛠️ ci(travis): run prettier on update by gr2m
🛠️ style: eslint-config-standard (#1324) by paulmelnikow
🛠️ style: prettier (#1311) by paulmelnikow
🛠️ Remove conditional for now-unsupported Node versions by paulmelnikow
🛠️ test(test_common): Pick up some coverage (#1317) by paulmelnikow
🛠️ test(test_back): Fix test broken in merge conflict by paulmelnikow
🛠️ ci(package): update semantic-release to beta.13 by gr2m
🛠️ test(test_back): Cover both of the ‘no fs’ code paths by paulmelnikow
🛠️ test(test_data): Remove a wide-bracket regression test This was a regression test for https://github.com/nock/nock/issues/328. It’s not clear exactly how the test case relates to the issue. I imagine other tests cover this, though it’s difficult to know without going back in time and digging through it. The fix was for an old and very specific version of Node. by paulmelnikow
🛠️ test(test_complex_querystring): Rewrite using got, qs, async/await (#1313) by paulmelnikow
🛠️ test(test_content_encoding): Rewrite using got, async/await by paulmelnikow
🛠️ test(test_back): Import test from tap for consistency by paulmelnikow
🛠️ Set up Prettier by paulmelnikow
🛠️ test(test_common): Rewrite in more direct style (#1306) by paulmelnikow
🛠️ refactor: Fix some errors detected by LGTM (#1301) https://lgtm.com/projects/g/nock/nock/alerts/?mode=list by paulmelnikow
🛠️ test(back): Fill in code coverage proxyquire is a library I’ve used for testing library behavior when imports are present or absent. by paulmelnikow
🛠️ refactor(mixin): Remove dead code (#1295) These two lines are not covered by code coverage. The function is called in one place, where it always has truthy arguments, so it seems simplest to remove this behavior. by paulmelnikow
🛠️ refactor(socket): Remove dead code (#1296) by paulmelnikow
🛠️ test(test_basic_auth): Rewrite using got + async/await by paulmelnikow
🛠️ ci(travis): run release stage on [Version].x, next, beta branches by gr2m
🛠️ Drop support for Node 6 BREAKING CHANGE: Drop support for Node 6 Ref #1297 by paulmelnikow
🛠️ docs(CONTRIBUTING): Backport a fix / feature to a previous version by gr2m
🛠️ ci(travis): build on branches for semantic-release preview/next/maintenance releases by gr2m
🛠️ build(package): update semantic-release to ^16.0.0-beta.10 by gr2m
🛠️ test(test_back): Improve style and readability by paulmelnikow
🛠️ build(package): explicitly pipe lcov output to coveralls by gr2m
🛠️ ci: remove obsolete coveralls configuration by gr2m
🛠️ test(test_s3): Add fixme comment by paulmelnikow
🛠️ test(test_aws_dynamo): Remove AWS Dynamo functional test This reverts 90662fc1fcc74586b157dddd5a408a692579ff20 which added a wide-bracket functional test for #223. I appreciate the goal of defensively avoiding a regression. I could imagine circumstances where it’s worth installing some prominent client library to ensure nock keeps working with some complex workflow. However the default when finding a bug in nock should be to isolate the bug in a small test case, and continue to maintain that small example to protect from regressions. In this case there wasn’t even a bug. There’s another regression test for #256 which also uses aws-sdk but that’s going to take a bit more effort to rework. by paulmelnikow
🛠️ test(test_abort): Improve style + readability by paulmelnikow
🛠️ test: Replace lodash with native in tests by paulmelnikow
🛠️ chore: Ignore ‘tests/ssl/index.js’ for coverage by paulmelnikow
🛠️ Clean lint by paulmelnikow
🛠️ test(test_recorder): De-airplane remaining recorder tests by paulmelnikow
🛠️ build(package): pipe to coveralls by setting ENV variable by gr2m
🛠️ test(test_recorder): De-airplane more recorder tests Ref #1077 by paulmelnikow

---

CONTRIBUTORS

Last week there were 2 contributors.
👤 paulmelnikow
👤 gr2m

---

STARGAZERS

Last week there were 45 stagazers.
⭐ yxliang01
⭐ piecioshka
⭐ ranyitz
⭐ zsevic
⭐ Glanms
⭐ makotot
⭐ tragrz
⭐ shekharhimanshu
⭐ usherwong
⭐ pdarii
⭐ Talento90
⭐ qfish
⭐ Cherry
⭐ sanjaypojo
⭐ aniiantt
⭐ zhipenglin
⭐ sealedace
⭐ dontry
⭐ CRL7
⭐ SaadShamim
⭐ kwood15
⭐ otaro808
⭐ yofriadi
⭐ AIBottle
⭐ gentean
⭐ sakoh
⭐ protoEvangelion
⭐ igarashii
⭐ shawjia
⭐ licanbluesea
⭐ skitterm
⭐ onildoaguiar
⭐ foo4foo
⭐ haxzie
⭐ nbfujx
⭐ yds05
⭐ OCDpunk
⭐ germanrcuriel
⭐ tjenkinson
⭐ codeitcody
⭐ snowdream
⭐ iquabius
⭐ b5156
⭐ wenshin
⭐ sysaxis
You all are the stars! 🌟

---

RELEASES

Last week there was 1 release.
🚀 v11.0.0-beta.1@beta v11.0.0-beta.1

---

That's all for last week, please 👀 Watch and ⭐ Star the repository nock/nock to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

[gr2m]

Awesome week :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!